Add CodeSystem $lookup operation to Frontend UI#3618
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3618 +/- ##
==========================================
- Coverage 96.12% 96.11% -0.01%
==========================================
Files 414 414
Lines 25855 25879 +24
Branches 643 643
==========================================
+ Hits 24852 24874 +22
Misses 476 476
- Partials 527 529 +2
🚀 New features to boost your workflow:
|
xmyno
force-pushed
the
3521-fe-codesystem-lookup
branch
from
e3d55e6 to
bbe88c4
Compare
| if (!res.ok) { | ||
| const error: OperationOutcome = await res.json(); | ||
| return fail(400, { | ||
| code, |
There was a problem hiding this comment.
please deduplicate like in $validate-code/+page.server.ts
| if (!res.ok) { | ||
| const error: OperationOutcome = await res.json(); | ||
| return fail(400, { | ||
| system, |
There was a problem hiding this comment.
please deduplicate like in $validate-code/+page.server.ts
| <Row title={'Property[' + i + ']'}> | ||
| <DescriptionList> | ||
| {#each property.part as part} | ||
| <Row title={part.name}>{parameterValue(part)}</Row> |
There was a problem hiding this comment.
Please look if you can use src/lib/resource/property.svelte here. Otherwise complex types like Coding are not rendered to text.
| display, | ||
| displayLanguage, | ||
| incorrect: true, | ||
| msg: error.issue[0]?.diagnostics ?? error.issue[0]?.details?.text |
There was a problem hiding this comment.
error.issue can be missing, so error.issue?.[0] would be better. Please also replace that everywhere else.
| "value" value | ||
| "description" description | ||
| "source" source]) | ||
| (def ^:private concept-properties |
There was a problem hiding this comment.
Dead :display keys in concept-properties (terminology_service/local/lookup.clj:11–63). Only :description is read by standard-property-description. Either drop :display from every
entry, or wire it up — currently it's misleading dead data.
2 participants
Closes #3521