[ryoppippi]

Summary

The nix-darwin module only set commit.gpgsign, so annotated tags were left unsigned even with signByDefault = true. The home-manager module already signs both, because home-manager derives commit.gpgSign and tag.gpgSign from signing.signByDefault.

What Changed

• modules/darwin-module.nix: set tag.gpgsign alongside commit.gpgsign in the activation script, driven by the same signByDefault value.
• modules/options.nix: mention tags in the signByDefault option description.
• README.md: update the signByDefault comments to cover tags.

Testing

• nix flake check passes.

Summary by CodeRabbit

• New Features

  • Git tags are now signed automatically alongside Git commits when default signing is enabled.
  • Tag signing uses the same configured SSH signing settings as commit signing.

• Documentation

  • Updated configuration examples and option descriptions to clarify that default signing applies to both Git commits and tags.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 23acee85-f027-4c04-9381-936005b6802c

📥 Commits

Reviewing files that changed from the base of the PR and between 045e15b and 1da505b.

📒 Files selected for processing (3)

• README.md
• modules/darwin-module.nix
• modules/options.nix

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The activation configuration now sets global Git tag signing based on signByDefault. The option description and all README configuration examples document signing for both Git commits and tags.

Changes

Git signing configuration

Layer / File(s)	Summary
Configure tag signing modules/darwin-module.nix, modules/options.nix	Activation sets Git tag.gpgsign from cfg.signByDefault. The option description includes Git tags.
Update configuration examples README.md	The nix-darwin, declarative identity, and Home Manager examples state that commits and tags are signed by default.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 1da50

The change enables signing of annotated Git tags alongside commits when signByDefault is enabled. The supplied check passes, and no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: enabling Git tag signing when signByDefault is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/darwin-tag-gpgsign

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}