Skip to content

Fix bootstrap window reopening over scenario#922

Merged
notfood merged 1 commit into
rwmt:devfrom
MhaWay:fix-bootstrap-window-over-scenario
May 15, 2026
Merged

Fix bootstrap window reopening over scenario#922
notfood merged 1 commit into
rwmt:devfrom
MhaWay:fix-bootstrap-window-over-scenario

Conversation

@MhaWay
Copy link
Copy Markdown
Contributor

@MhaWay MhaWay commented May 15, 2026

Summary

  • remove the early bootstrap StartedNewGame trigger that could re-open the bootstrap window before map initialization had actually finished
  • rely on the map initialization path to re-show the bootstrap UI only when the world is ready
  • show a clear waiting message for controllable colonists after the map finishes initializing

Testing

  • dotnet test .\Tests\Tests.csproj --filter BootstrapSettingsTest

Copilot AI review requested due to automatic review settings May 15, 2026 07:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the client bootstrap flow to prevent the Bootstrap Configurator window from re-opening too early during new-game creation, and updates the UI messaging to reflect the actual wait condition after map initialization.

Changes:

  • Removed the StartedNewGame Harmony patch that could trigger OnBootstrapMapInitialized before map initialization completed.
  • Updated the post-map-init status text to explicitly indicate waiting for controllable colonists to spawn.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Source/Client/Windows/BootstrapConfiguratorWindow.BootstrapFlow.cs Updates the bootstrap status message shown after map initialization.
Source/Client/Patches/BootstrapStartedNewGamePatch.cs Removes an early bootstrap trigger that could re-open the window prematurely.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@notfood notfood added fix Fixes for a bug or desync. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). standalone server Fix or bugs relating to the standalone server. labels May 15, 2026
@notfood notfood merged commit 76eed6e into rwmt:dev May 15, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). fix Fixes for a bug or desync. standalone server Fix or bugs relating to the standalone server.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants