Fix bootstrap window reopening over scenario#922
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the client bootstrap flow to prevent the Bootstrap Configurator window from re-opening too early during new-game creation, and updates the UI messaging to reflect the actual wait condition after map initialization.
Changes:
- Removed the
StartedNewGameHarmony patch that could triggerOnBootstrapMapInitializedbefore map initialization completed. - Updated the post-map-init status text to explicitly indicate waiting for controllable colonists to spawn.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Source/Client/Windows/BootstrapConfiguratorWindow.BootstrapFlow.cs | Updates the bootstrap status message shown after map initialization. |
| Source/Client/Patches/BootstrapStartedNewGamePatch.cs | Removes an early bootstrap trigger that could re-open the window prematurely. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing