Clean up standalone save/persistence review noise#920
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR cleans up follow-up noise around standalone save/persistence and tightens a couple of server-side behaviors without changing the broader architecture.
Changes:
- Re-enabled cache handoff during save/reload and removed leftover commented-out code.
- Added server-side chat length clamping and dev-mode gating for debug packets.
- Clarified comments/formatting and added focused debug-gate tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Source/Tests/StandaloneMapStreamingTest.cs | Adds tests for debug packet behavior with dev mode disabled/enabled. |
| Source/Common/Networking/State/ServerPlayingState.cs | Clamps chat messages and rejects debug handling when dev mode is unavailable. |
| Source/Client/Saving/SaveLoad.cs | Restores cache handoff assignments during save/reload. |
| Source/Client/Patches/VTRSyncPatch.cs | Clarifies the synchronized VTR update-rate comment. |
| Source/Client/ConstantTicker.cs | Adjusts autosave branch formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
notfood
approved these changes
May 14, 2026
mibac138
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a cleanup-only follow-up for the standalone save/persistence work already merged in 0dea755.
The goal is to reduce review noise around that code so the remaining logic is easier to read.
Changes
Validation