Repository navigation
Conversation
## Problem Summary Windows native builds were failing while resolving the `ndarray-linalg` / OpenBLAS dependency chain because the workspace forced `openblas-static` everywhere. On Windows, that pulled `openblas-src` into a non-vcpkg build path that it does not support. ## Reproduction Conditions - Windows 11 - Git Bash / MINGW64 - Rust/Cargo workspace build - vcpkg and OpenBLAS installed locally - Python 3.14 - Docker Desktop available - RTX 3050 laptop GPU present - Failure observed during `./install.sh`, Rust profile installation, and workspace compilation on the Windows native path ## Root Cause The workspace previously pinned `ndarray-linalg` in the root Cargo manifest with `openblas-static` for all targets. That propagated into `lax -> openblas-src`, which then attempted an unsupported Windows build mode. The error surfaced as: > `openblas-src v0.10.15: Non-vcpkg builds are not supported on Windows. You must use the 'system' feature.` ## Fix This patch makes the backend choice explicit and target-specific: - Windows uses `openblas-system` - non-Windows targets keep `openblas-static` - the default `ndarray-linalg` feature wiring in `wifi-densepose-signal` is made explicit with `dep:ndarray-linalg` That preserves existing Linux/macOS behavior while making the Windows path use the system OpenBLAS/vcpkg-compatible route. ## Why `openblas-src` Failed on Windows `openblas-src` does not support the non-vcpkg build path on Windows. When `ndarray-linalg` selected `openblas-static`, Cargo ultimately asked `openblas-src` to build or bundle OpenBLAS in a way that is unsupported on Windows. The `system` feature is the supported Windows path because it uses the system-provided OpenBLAS installation instead of the unsupported bundled/static path. ## Dependency / Backend Selection Changes - Removed the workspace-wide `ndarray-linalg` backend pin from the root `Cargo.toml` - Moved ownership of the `ndarray-linalg` dependency into `crates/wifi-densepose-signal/Cargo.toml` - Selected `openblas-system` on Windows and `openblas-static` elsewhere - Kept the signal crate’s default `eigenvalue` feature wired to the optional BLAS-backed dependency ## Validation - `cargo check --workspace` completed successfully - The workspace build now resolves `ndarray-linalg` without tripping the unsupported Windows OpenBLAS build path ## Expected Impact - Windows users can build the workspace without hitting the `openblas-src` non-vcpkg failure - Linux and macOS builds continue using the existing static/bundled behavior - No runtime code, APIs, or signal-processing logic were changed ## Cargo.lock Considerations - A local Cargo re-resolution was observed during validation - No lockfile churn is included in this commit because the fix itself is manifest-only and the regenerated local lock delta was incidental to validation ## Changed Files - `v2/Cargo.toml` - `v2/crates/wifi-densepose-signal/Cargo.toml`
#2530) openblas-src rejects its static build on Windows ("Non-vcpkg builds are not supported on Windows"), so a default-feature build of wifi-densepose-signal could not compile there. Declare ndarray-linalg per target: openblas-system on Windows, openblas-static elsewhere. Both stay optional, so --no-default-features still drops BLAS entirely. Ported from #825 by @PretaxE63, keeping the dependency optional (the original made it unconditional, which re-added BLAS to every default-features = false consumer) and dropping an unrelated regenerated Tauri schema. Co-authored-by: Uxsshann <usattha@gmail.com>
|
Thank you @PretaxE63 for tracking this down and for the clear write-up. The Windows fix was still needed on main, so it has landed as #2530 (merged as 48f8091), with your commit authorship and a Co-authored-by trailer preserved. It is not merged verbatim for one reason: the target-specific |
…igenvalue feature (ruvnet#2530) openblas-src rejects its static build on Windows ("Non-vcpkg builds are not supported on Windows"), so a default-feature build of wifi-densepose-signal could not compile there. Declare ndarray-linalg per target: openblas-system on Windows, openblas-static elsewhere. Both stay optional, so --no-default-features still drops BLAS entirely. Ported from ruvnet#825 by @PretaxE63, keeping the dependency optional (the original made it unconditional, which re-added BLAS to every default-features = false consumer) and dropping an unrelated regenerated Tauri schema. Co-authored-by: Uxsshann <usattha@gmail.com> 48f8091
Problem Summary
Windows native builds were failing while resolving the
ndarray-linalg/ OpenBLAS dependency chain because the workspace forcedopenblas-staticeverywhere. On Windows, that pulledopenblas-srcinto a non-vcpkg build path that it does not support.Reproduction Conditions
./install.sh, Rust profile installation, and workspace compilation on the Windows native pathRoot Cause
The workspace previously pinned
ndarray-linalgin the root Cargo manifest withopenblas-staticfor all targets. That propagated intolax -> openblas-src, which then attempted an unsupported Windows build mode. The error surfaced as:Fix
This patch makes the backend choice explicit and target-specific:
openblas-systemopenblas-staticndarray-linalgfeature wiring inwifi-densepose-signalis made explicit withdep:ndarray-linalgThat preserves existing Linux/macOS behavior while making the Windows path use the system OpenBLAS/vcpkg-compatible route.
Why
openblas-srcFailed on Windowsopenblas-srcdoes not support the non-vcpkg build path on Windows. Whenndarray-linalgselectedopenblas-static, Cargo ultimately askedopenblas-srcto build or bundle OpenBLAS in a way that is unsupported on Windows. Thesystemfeature is the supported Windows path because it uses the system-provided OpenBLAS installation instead of the unsupported bundled/static path.Dependency / Backend Selection Changes
ndarray-linalgbackend pin from the rootCargo.tomlndarray-linalgdependency intocrates/wifi-densepose-signal/Cargo.tomlopenblas-systemon Windows andopenblas-staticelsewhereeigenvaluefeature wired to the optional BLAS-backed dependencyValidation
cargo check --workspacecompleted successfullyndarray-linalgwithout tripping the unsupported Windows OpenBLAS build pathExpected Impact
openblas-srcnon-vcpkg failureCargo.lock Considerations
Changed Files
v2/Cargo.tomlv2/crates/wifi-densepose-signal/Cargo.toml