Repository navigation
ci: test wifi-densepose-signal's default feature set - #2539
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
`eigenvalue` is the crate's default feature, but every cargo invocation in this workflow passes --no-default-features, so nothing in CI compiles it. grep -rn eigenvalue .github/workflows/ returns no hits. What that leaves uncovered: the Marcenko-Pastur occupancy estimator, the baseline_count path in finalize_calibration, and the four #[cfg(feature = "eigenvalue")] test modules in ruvsense/field_model.rs. ruvnet#2530 fixed the Windows OpenBLAS build for this feature, and no job builds the configuration it fixed. Add a step alongside the existing per-feature steps for cir and fann-shadow, which exist for the same reason. Verified locally (Rust 1.89.0, openblas-static built from source): cargo test -p wifi-densepose-signal --features eigenvalue 553 passed, 0 failed including ruvsense::field_model::tests::test_baseline_eigenvalue_count_stored, which the default workspace run filters out.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
eigenvalueiswifi-densepose-signal's default feature:But every cargo invocation in
ci.ymlpasses--no-default-features:So the crate's default configuration is never compiled or run in CI. What that leaves uncovered:
ruvsense/field_model.rs)baseline_countpath infinalize_calibration#[cfg(feature = "eigenvalue")]test modules infield_model.rsThis is live rather than theoretical: #2530 ("use system OpenBLAS on Windows for the eigenvalue feature") landed recently as a build fix for a configuration no job builds, so nothing demonstrates it works.
Change
One step, placed beside the existing per-feature steps for
cirandfann-shadow— both of which exist for exactly this reason ("the default workspace run never compiles it"):Validation
I ran the proposed command before proposing it, on Rust 1.89.0 with
openblas-staticbuilt from source:That last test is filtered out of the default workspace run, which is the point. A preceding
cargo check -p wifi-densepose-signal --features eigenvaluealso passed (exit 0), buildingndarray-linalg 0.18.1andlax 0.18.0.Cost, honestly
On non-Windows the crate selects
openblas-static, so the first CI run compiles OpenBLAS from source. My localcargo checkof that dependency graph took 19m31s cold. This job already usesSwatinem/rust-cache, so the cost should amortize after the first run, but the first run is real and I would rather state it than let you discover it.If that is unwelcome on every push, two smaller variants work equally well and I am happy to switch to either: put the step behind a
paths:filter onv2/crates/wifi-densepose-signal/**, or move it to a separate scheduled workflow. The thing worth having is some job that compiles the default feature set; which trigger it hangs off is your call.What I did not do: I ran this on macOS (arm64), not on an
ubuntu-latestrunner, so I have not observed the apt/OpenBLAS path CI will actually take. And I deliberately left #1940 alone — exposing an opt-ineigenvaluefeature on the sensing-server so the estimator is reachable in the shipped binary is a separate change, and it should land on top of a job that proves the feature works rather than before one.