Skip to content

ci: test wifi-densepose-signal's default feature set - #2539

Open
rudycelekli wants to merge 1 commit into
ruvnet:mainfrom
rudycelekli:feat/cover-eigenvalue-occupancy-path
Open

rudycelekli wants to merge 1 commit into
ruvnet:mainfrom
rudycelekli:feat/cover-eigenvalue-occupancy-path

Conversation

@rudycelekli

Copy link
Copy Markdown

Problem

eigenvalue is wifi-densepose-signal's default feature:

# v2/crates/wifi-densepose-signal/Cargo.toml
default = ["eigenvalue"]
eigenvalue = ["ndarray-linalg"]

But every cargo invocation in ci.yml passes --no-default-features:

ci.yml:140  cargo test --workspace --no-default-features
ci.yml:164  cargo test -p wifi-densepose-signal --no-default-features --features cir --tests
$ grep -rn "eigenvalue" .github/workflows/
(no output)

So the crate's default configuration is never compiled or run in CI. What that leaves uncovered:

  • the Marcenko-Pastur occupancy estimator (ruvsense/field_model.rs)
  • the baseline_count path in finalize_calibration
  • the four #[cfg(feature = "eigenvalue")] test modules in field_model.rs

This is live rather than theoretical: #2530 ("use system OpenBLAS on Windows for the eigenvalue feature") landed recently as a build fix for a configuration no job builds, so nothing demonstrates it works.

Change

One step, placed beside the existing per-feature steps for cir and fann-shadow — both of which exist for exactly this reason ("the default workspace run never compiles it"):

- name: Run eigenvalue (default feature) signal tests
  working-directory: v2
  run: cargo test -p wifi-densepose-signal --features eigenvalue

Validation

I ran the proposed command before proposing it, on Rust 1.89.0 with openblas-static built from source:

cargo test -p wifi-densepose-signal --features eigenvalue
→ exit 0
→ 553 passed, 0 failed (across all targets, including doctests)
→ includes ruvsense::field_model::tests::test_baseline_eigenvalue_count_stored

That last test is filtered out of the default workspace run, which is the point. A preceding cargo check -p wifi-densepose-signal --features eigenvalue also passed (exit 0), building ndarray-linalg 0.18.1 and lax 0.18.0.

Cost, honestly

On non-Windows the crate selects openblas-static, so the first CI run compiles OpenBLAS from source. My local cargo check of that dependency graph took 19m31s cold. This job already uses Swatinem/rust-cache, so the cost should amortize after the first run, but the first run is real and I would rather state it than let you discover it.

If that is unwelcome on every push, two smaller variants work equally well and I am happy to switch to either: put the step behind a paths: filter on v2/crates/wifi-densepose-signal/**, or move it to a separate scheduled workflow. The thing worth having is some job that compiles the default feature set; which trigger it hangs off is your call.

What I did not do: I ran this on macOS (arm64), not on an ubuntu-latest runner, so I have not observed the apt/OpenBLAS path CI will actually take. And I deliberately left #1940 alone — exposing an opt-in eigenvalue feature on the sensing-server so the estimator is reachable in the shipped binary is a separate change, and it should land on top of a job that proves the feature works rather than before one.

`eigenvalue` is the crate's default feature, but every cargo invocation
in this workflow passes --no-default-features, so nothing in CI compiles
it. grep -rn eigenvalue .github/workflows/ returns no hits.

What that leaves uncovered: the Marcenko-Pastur occupancy estimator, the
baseline_count path in finalize_calibration, and the four
#[cfg(feature = "eigenvalue")] test modules in ruvsense/field_model.rs.
ruvnet#2530 fixed the Windows OpenBLAS build for this feature, and no job
builds the configuration it fixed.

Add a step alongside the existing per-feature steps for cir and
fann-shadow, which exist for the same reason.

Verified locally (Rust 1.89.0, openblas-static built from source):
cargo test -p wifi-densepose-signal --features eigenvalue
  553 passed, 0 failed
including ruvsense::field_model::tests::test_baseline_eigenvalue_count_stored,
which the default workspace run filters out.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant