Skip to content

Adjust test-sites.json churn rate#102

Merged
ctz merged 3 commits intomainfrom
jbp-adjust-test-data-churn
Apr 15, 2026
Merged

Adjust test-sites.json churn rate#102
ctz merged 3 commits intomainfrom
jbp-adjust-test-data-churn

Conversation

@ctz
Copy link
Copy Markdown
Member

@ctz ctz commented Apr 15, 2026

Prior to this PR any expired cert in test-sites.json causes test failure. This replaces it with a 30-day expiry of the data set, along with acceptance of expired certs.

@ctz ctz force-pushed the jbp-adjust-test-data-churn branch from 2c06650 to 227c6f4 Compare April 15, 2026 11:56
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 15, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing jbp-adjust-test-data-churn (9fcb71b) with main (fdc7153)

Open in CodSpeed

@ctz ctz force-pushed the jbp-adjust-test-data-churn branch from 227c6f4 to e80cdce Compare April 15, 2026 12:03
@ctz ctz requested a review from Copilot April 15, 2026 13:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces churn in revoke-test/test-sites.json by adding an explicit dataset freshness window (30 days) and adjusting system tests to tolerate certificates that have expired since the dataset was generated.

Changes:

  • Add a timestamp to RevocationTestSites and an expired() helper to enforce a 30-day dataset TTL.
  • Update system tests to fail fast on an expired dataset and to classify rustls certificate expiry errors as TestResult::Expired.
  • Regenerate/update test-sites.json content to include the new timestamp field and refreshed certificate/error details.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
revoke-test/tests/system_tests.rs Adds dataset TTL assertion; adds handling/reporting for expired-certificate verification outcomes.
revoke-test/test-sites.json Updates test vectors and adds a top-level timestamp used for dataset TTL.
revoke-test/src/lib.rs Extends RevocationTestSites with timestamp and implements 30-day expiration logic.
revoke-test/src/bin/fetch.rs Writes the current Unix timestamp into the generated test-sites.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread revoke-test/tests/system_tests.rs
Comment thread revoke-test/src/lib.rs
Comment thread revoke-test/src/lib.rs
Copy link
Copy Markdown
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ctz ctz force-pushed the jbp-adjust-test-data-churn branch from e80cdce to 13a962c Compare April 15, 2026 15:14
@ctz ctz force-pushed the jbp-adjust-test-data-churn branch from 13a962c to 9fcb71b Compare April 15, 2026 15:22
@ctz ctz added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit ca79075 Apr 15, 2026
9 checks passed
@ctz ctz deleted the jbp-adjust-test-data-churn branch April 15, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants