Conversation
2c06650 to
227c6f4
Compare
227c6f4 to
e80cdce
Compare
There was a problem hiding this comment.
Pull request overview
This PR reduces churn in revoke-test/test-sites.json by adding an explicit dataset freshness window (30 days) and adjusting system tests to tolerate certificates that have expired since the dataset was generated.
Changes:
- Add a
timestamptoRevocationTestSitesand anexpired()helper to enforce a 30-day dataset TTL. - Update system tests to fail fast on an expired dataset and to classify rustls certificate expiry errors as
TestResult::Expired. - Regenerate/update
test-sites.jsoncontent to include the new timestamp field and refreshed certificate/error details.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| revoke-test/tests/system_tests.rs | Adds dataset TTL assertion; adds handling/reporting for expired-certificate verification outcomes. |
| revoke-test/test-sites.json | Updates test vectors and adds a top-level timestamp used for dataset TTL. |
| revoke-test/src/lib.rs | Extends RevocationTestSites with timestamp and implements 30-day expiration logic. |
| revoke-test/src/bin/fetch.rs | Writes the current Unix timestamp into the generated test-sites.json. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e80cdce to
13a962c
Compare
13a962c to
9fcb71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR any expired cert in test-sites.json causes test failure. This replaces it with a 30-day expiry of the data set, along with acceptance of expired certs.