Fix use-after free issues with shader programs - #84
Merged
Conversation
Member
|
The only thing I want to correct is the absorption of "Entrypoint" into "Library", while they are supposed to be separate concepts. Afaik, multiple Either way, I'm fine with the changes. |
Contributor
Author
|
I've updated it so that Also while creating the examples, I noticed that there's no method to get the location of a uniform in the geometry shader so I've added that too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix both use-after-errors mentioned in #53, by making
shader::Programown theshader::Librarythat it uses, and by makingshader::Libraryown the underlying bytes of the compiled shader.