Skip to content

Give crater permissions to the triage team#2449

Open
cuviper wants to merge 1 commit intorust-lang:mainfrom
cuviper:crater-triage
Open

Give crater permissions to the triage team#2449
cuviper wants to merge 1 commit intorust-lang:mainfrom
cuviper:crater-triage

Conversation

@cuviper
Copy link
Copy Markdown
Member

@cuviper cuviper commented Apr 28, 2026

We in the release team have appreciated the triage team's help with beta crater reports, especially @theemathas, and they may do more with the ability to queue crater jobs themselves.

r? @Mark-Simulacrum

@rustbot
Copy link
Copy Markdown

rustbot commented Apr 28, 2026

Error: The feature assign is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@cyrgani
Copy link
Copy Markdown
Contributor

cyrgani commented Apr 28, 2026

#2002 was a previous proposal for this (but only for try permissions), which was declined.

@cuviper
Copy link
Copy Markdown
Member Author

cuviper commented Apr 28, 2026

Well at least for beta crater runs, they don't need the ability to create new builds, try or otherwise.

@jackh726
Copy link
Copy Markdown
Member

I have a general negative sentiment on this, echoing @jieyouxu's concern. The bar for triage membership is low. I like the idea of it, but expanding permissions more than what is already allowed (which, tbh, I have thought a ton about) makes me weary.

I think it's better to do one or more of the following:

  1. Limit membership to "trusted and active contributors"
  2. Split triage into two teams, a "trusted" team and then a untrusted team (where the former can have try and crater permissions, probably move issues across repos, close issues, close PRs; the latter can label issues).
  3. Make sure that people doing things like crater triage are part of a team that does have these permissions.

@Mark-Simulacrum
Copy link
Copy Markdown
Member

I would personally continue to be hesitant about try permissions, but crater should be fairly safe. In principle you can still cause damage but we grant triage members permissions to do that anyway in other ways (and, honestly, I don't know how worried I am - the worst case is pretty benign here, I think).

@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented May 2, 2026

Another possible approach (without having to explicitly recharter triage team into two teams just yet, which I last understand was something that's in the works) could also be something like a release/crater-triage subteam (who don't receive the 'full' release team permissions but do get try / crater permissions, e.g. I would trust theemathas with try permissions). Up to y'all.

@jieyouxu jieyouxu added needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants