Remove interior mutability in mir predecessors cache#64736

Merged

bors merged 47 commits into

rust-lang:masterfrom

Nashenas88:mir_predecessors_cache_cleanup

Dec 2, 2019

Commits on Dec 2, 2019

Remove interior mutability in mir predecessors cache
Nashenas88
committed
Inline cache impl into Body, rename predecessor fns, change output of predecessors_for to slice
Nashenas88
committed
Get rid of old comment
Nashenas88
committed
Stop invalidating predecessors cache when accessing unique basic block, invalidate cache when accessing unique terminator
Nashenas88
committed
Add pass to ensure predecessors cache is generated after optimization
Nashenas88
committed
Fix Mir visitor macro to ensure it calls the proper method to invalidate the predecessors cache
Nashenas88
committed
Address linting errors caught by CI
Nashenas88
committed
Ensure predecessors are recomputed at critical points, fixes panics
Nashenas88
committed
Move predecessors cache invalidation back to basic_blocks_mut, add a couple more ensure_predecessors to prevent panics
Nashenas88
committed
Address excessive line length that was triggering warning during linting
Nashenas88
committed
Address nits and remove unneeded pass
Nashenas88
committed
Add back cache invalidation to basic_blocks_and_local_decls_mut
Nashenas88
committed
Move predecessors cache back to its own type
Nashenas88
committed
Move predecessor cache outside of Body, use wrapper types to manage Cache and Body (WIP, amend this commit)
Nashenas88
committed
Simplify Cache wrapper to single type, impl Deref on it, fix all compilation errors in librustc_codegen_ssa
Nashenas88
committed
Remove Body from FunctionCx, pass it along during librustc_codegen_ssa
Nashenas88
committed
Improved BodyCache body impl so it only returns a sharable ref, add new body_mut method, fix visit macros, simplify usage in codegen_ssa analyzer
Nashenas88
committed
Add Body back as field of FunctionCx, but under a different lifetime
Nashenas88
committed
Revert back to using FunctionCx's Body
Nashenas88
committed
Convert &mut to & since the reference didn't need to be mutable
Nashenas88
committed
Account for new maybe_sideeffect helper that requires predecessors
Nashenas88
committed
Fix a large number of Body -> (ReadOnly)BodyCache type errors, add predecessor_locations fn to ReadOnlyBodyCache
Nashenas88
committed
Add read_only fn to BodyCache<&mut...> impl, fix more Body -> (ReadOnly)BodyCache type errors
Nashenas88
committed
Add predecessors fn to ReadOnlyBodyCache, fix more Body -> (ReadOnly)BodyCache type errors
Nashenas88
committed
Fix typo caused by rebasing
Nashenas88
committed
Fix remaining Body -> (ReadOnly)BodyCache type errors in librustc_mir outside of librustc_mir/transform
Nashenas88
committed
Simplify BodyCache impl and fix all remaining type errors in librustc_mir (lifetime errors still exist)
Nashenas88
committed
Fix remaining compilation issues
Nashenas88
committed
Fix typos caused during rebase
Nashenas88
committed
Fix tidy errors
Nashenas88
committed
Fix typo
Nashenas88
committed
Fix compilation errors created during rebase
Nashenas88
committed
Undo minor changes that weren't needed, fix one lifetime typo
Nashenas88
committed
Remove BodyCache.body and rely on Deref as much as possible for ReadOnlyBodyCache
Nashenas88
committed
Remove HasLocalDecls impl from BodyCache's, properly reborrow to Body, rename all body_cache back to body
Nashenas88
committed
Fix typos caused during rebase
Nashenas88
committed
Remove files created during conflict resolution
Nashenas88
committed
Compute predecessors in mir_build query and use existing cache for generating ReadOnlyBodyCache, remove unneeded fns
Nashenas88
committed
Fix type errors cause during rebasing
Nashenas88
committed
Remove inline attributes that hadn't been profiled, unexport Cache since it no longer needs to be public
Nashenas88
committed
Remove unchecked inline attribute, remove unused functions, make chache mod private again
Nashenas88
committed
Fix type errors created during rebasing
Nashenas88
committed
Fix rebasing errors, convert some BodyCache::body() calls to reborrows
Nashenas88
committed
Fix tidy issues
Nashenas88
committed
Use new HashStable proc macro
Nashenas88
committed
Fix issues caused during rebasing
Nashenas88
committed
Fix issues caused during rebasing
Nashenas88
committed