Skip to content

Move and rename the clone-never.rs test#156079

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
JonathanBrouwer:clone-never
May 3, 2026
Merged

Move and rename the clone-never.rs test#156079
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
JonathanBrouwer:clone-never

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer commented May 2, 2026

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 2, 2026

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

JonathanBrouwer
JonathanBrouwer commented May 2, 2026
View reviewed changes
Comment thread tests/ui/never_type/basic/clone-never.rs
@@ -1,5 +1,3 @@
//! regression test for issue #2151
Copy link
Copy Markdown
Contributor Author

@JonathanBrouwer JonathanBrouwer May 2, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue if there was an issue number at some point, but #2151 is definitely not it

View changes since the review

Copy link
Copy Markdown
Contributor

@mejrs mejrs May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh yeah, it is. see also e67c48a#diff-3942c1707657c0f697df38d3f3455f37a43ead33041c1bf91bcb89d79021edac

Copy link
Copy Markdown
Contributor Author

@JonathanBrouwer JonathanBrouwer May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, crazy old issue number, I've restored the comment then, sorry. That PR title and description did not sound related.
Thanks for diving into it

Copy link
Copy Markdown
Contributor Author

@JonathanBrouwer JonathanBrouwer May 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah seems like the vec part was removed from the test in the diff you showed me. I'm fine with keeping the comment or not, whatever. My primary goal for this PR is moving the test to reduce the diff of #156047

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@mejrs
Copy link
Copy Markdown
Contributor

mejrs commented May 2, 2026

r? me

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 2, 2026

📌 Commit da58ae7 has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 2, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156079 - JonathanBrouwer:clone-never, r=mejrs
00d9219 
Move and rename the `clone-never.rs` test
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 2, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156079 - JonathanBrouwer:clone-never, r=mejrs
352afd8 
Move and rename the `clone-never.rs` test
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 2, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request May 3, 2026
@bors
Auto merge of #156095 - JonathanBrouwer:rollup-lAhgJ4U, r=JonathanBro…
6912d18 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #152277 (Validate source snippet when format input is raw string)
 - #155940 (refactor rustc_on_unimplemented's filtering)
 - #156065 (Remove unused spans from AttributeKind)
 - #156079 (Move and rename the `clone-never.rs` test)
 - #156091 (change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools`)
@jhpratt jhpratt mentioned this pull request May 3, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request May 3, 2026
@bors
Auto merge of #156097 - jhpratt:rollup-haL7A1y, r=jhpratt
6769f69 
Rollup of 5 pull requests

Successful merges:

 - #155666 (Interning cleanups)
 - #155940 (refactor rustc_on_unimplemented's filtering)
 - #156065 (Remove unused spans from AttributeKind)
 - #156079 (Move and rename the `clone-never.rs` test)
 - #156091 (change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools`)
@rust-bors rust-bors Bot merged commit 98d754b into rust-lang:main May 3, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 3, 2026
rust-timer added a commit that referenced this pull request May 3, 2026
@rust-timer
Unrolled build for #156079
361e45f 
Rollup merge of #156079 - JonathanBrouwer:clone-never, r=mejrs

Move and rename the `clone-never.rs` test
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mejrs mejrs mejrs left review comments

Assignees

@mejrs mejrs

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer @rustbot @rust-log-analyzer @mejrs @nnethercote