Move std::io::RawOsError to core::io#155574
Open
bushrat011899 wants to merge 3 commits intorust-lang:mainfrom
Open
Move std::io::RawOsError to core::io#155574bushrat011899 wants to merge 3 commits intorust-lang:mainfrom
std::io::RawOsError to core::io#155574bushrat011899 wants to merge 3 commits intorust-lang:mainfrom
Conversation
The hyperlink to `std::io::Error` will not be valid when moved to `core::io`. There is also a typo which I might as well fix while I'm here.
Inconsistently referenced through `std::sys` and `std::io`. Choosing `std::io` as the canonical source to make migration to `core::io` cleaner.
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Related: #154654
Description
As a part of moving components of
std::iointoalloc::ioandcore::io, there will need to be a new home for the typeRawOsError. In this PR, I propose moving it tocore::io, and removing it fromstd::sys. I suspect this will be quite controversial as it is a platform dependent type, but this is not the only instance of a type being conditioned ontarget_osincore(e.g.,core::osandcore::ffi).Since
RawOsErroris currently unstable, I think it's reasonable to make this move now, and worry about making it platform independent if/when it is stabilized (e.g., replacing it with a wrapper aroundisizeon all platforms).Notes