Skip to content

NVPTX: Drop support for old architectures and old ISAs#152443

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
kjetilkjeka:nvptx_drop_support_old_hw_and_isa
Apr 29, 2026
Merged

NVPTX: Drop support for old architectures and old ISAs#152443
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
kjetilkjeka:nvptx_drop_support_old_hw_and_isa

Conversation

@kjetilkjeka
Copy link
Copy Markdown
Contributor

@kjetilkjeka kjetilkjeka commented Feb 10, 2026 •
edited by rustbot
Loading

View all comments

This is the implementation of this MCP

I believe it was said that no FCP was needed, but if that is incorrect then the FCP is anyway scheduled to finish in 2 days so it can in any case be merged then.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 10, 2026

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 10, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 10, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 66 candidates
  • Random selection from 13 candidates

@kjetilkjeka
Copy link
Copy Markdown
Contributor Author

kjetilkjeka commented Feb 10, 2026

r? @ZuseZ4

@rustbot rustbot assigned ZuseZ4 and unassigned jackh726 Feb 10, 2026
@kjetilkjeka
Copy link
Copy Markdown
Contributor Author

kjetilkjeka commented Feb 10, 2026

CC: @workingjubilee @kulst

@kjetilkjeka
Copy link
Copy Markdown
Contributor Author

kjetilkjeka commented Feb 10, 2026

@rustbot label +O-NVPTX

@rustbot rustbot added the O-NVPTX Target: the NVPTX LLVM backend for running rust on GPUs, https://llvm.org/docs/NVPTXUsage.html label Feb 10, 2026
kjetilkjeka
kjetilkjeka commented Feb 10, 2026
View reviewed changes
Comment thread compiler/rustc_target/src/target_features.rs
@kjetilkjeka kjetilkjeka changed the title NVPTX: Drop support for old hw and old ISAs NVPTX: Drop support for old architectures and old ISAs Feb 10, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@kjetilkjeka kjetilkjeka force-pushed the nvptx_drop_support_old_hw_and_isa branch from af90fab to 192c99f Compare February 10, 2026 16:53
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@kjetilkjeka kjetilkjeka force-pushed the nvptx_drop_support_old_hw_and_isa branch from 192c99f to a516a55 Compare February 10, 2026 17:44
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@kjetilkjeka kjetilkjeka force-pushed the nvptx_drop_support_old_hw_and_isa branch from a516a55 to 5f88388 Compare February 10, 2026 17:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@kjetilkjeka kjetilkjeka force-pushed the nvptx_drop_support_old_hw_and_isa branch 3 times, most recently from 4cbf1bb to 9026a42 Compare February 10, 2026 21:12
@ZuseZ4
Copy link
Copy Markdown
Member

ZuseZ4 commented Feb 11, 2026

Changing a target baseline officially doesn't require a blog post: https://forge.rust-lang.org/compiler/proposals-and-stabilization.html#other-kind-of-target-changes

But since it's afaik the first time that we raise it for a GPU target and since nvptx is Tier 2, would you mind to still write one, so that we could merge it simultaneously?

https://blog.rust-lang.org/2023/09/25/Increasing-Apple-Version-Requirements/ and https://blog.rust-lang.org/2025/08/19/demoting-x86-64-apple-darwin-to-tier-2-with-host-tools/ are two related examples, but there are more if you want some inspiration.

Just a more user-friendly, short version of your MCP. Something motivating the change, mentioning the new behaviour, and saying that we will likely raise it further in the future, would be enough.

@CodesInChaos
Copy link
Copy Markdown

CodesInChaos commented Feb 12, 2026

So this drops support for Pascal (10 series, P100), while keeping support for Volta (V100) and Turing (16 and 20 series)? Perhaps including that information in the docs would be helpful.

@kjetilkjeka kjetilkjeka force-pushed the nvptx_drop_support_old_hw_and_isa branch from 9026a42 to e04ea32 Compare March 4, 2026 16:56
@rustbot

This comment has been minimized.

Sign in to view
@kjetilkjeka kjetilkjeka force-pushed the nvptx_drop_support_old_hw_and_isa branch from e04ea32 to dc1bd5a Compare March 4, 2026 16:57
@kjetilkjeka
Copy link
Copy Markdown
Contributor Author

kjetilkjeka commented Mar 4, 2026 •
edited
Loading

With regards to blogpost, is something like this acceptable? rust-lang/blog.rust-lang.org#1810

So this drops support for Pascal (10 series, P100), while keeping support for Volta (V100) and Turing (16 and 20 series)? Perhaps including that information in the docs would be helpful.

Yes. I linked to the document by Nvidia listing all their GPUs as it will quickly become very verbose to explicitly list a lot of GPUs. Let me know if you think it's easier to get hold of this information with these changes.

Since the branch date for 1.95 was approaching I decided to instead wait for 1.96. The version is stated to be 1.96 in the docs and blogpost right now and we should have plenty of time for that branch date.

rust-bors Bot pushed a commit that referenced this pull request Apr 28, 2026
@bors
Auto merge of #152443 - kjetilkjeka:nvptx_drop_support_old_hw_and_isa…
d949a8b 
…, r=<try>

NVPTX: Drop support for old architectures and old ISAs


try-job: test-various
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

☀️ Try build successful (CI)
Build commit: d949a8b (d949a8b1a70add55ae252439e83d78c50873d3e2, parent: 03c609abb6638f9d7f49f34326d4137d07f5cd61)

@ZuseZ4
Copy link
Copy Markdown
Member

ZuseZ4 commented Apr 28, 2026

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

📌 Commit a2d23ce has been approved by ZuseZ4

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 28, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 28, 2026
@bors
Auto merge of #152443 - kjetilkjeka:nvptx_drop_support_old_hw_and_isa…
c7b0a6c 
…, r=ZuseZ4

NVPTX: Drop support for old architectures and old ISAs



This is the implementation of [this MCP](rust-lang/compiler-team#965 (comment))

I believe it was said that no FCP was needed, but if that is incorrect then the FCP is anyway scheduled to finish in 2 days so it can in any case be merged then.
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 28, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

💔 Test for c7b0a6c failed: CI. Failed job:

@ZuseZ4
Copy link
Copy Markdown
Member

ZuseZ4 commented Apr 28, 2026 •
edited
Loading

spurious. "No space left on device".

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

📌 Commit a2d23ce has been approved by ZuseZ4

It is now in the queue for this repository.

A failed build status on this PR was cleared due to the approval.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Apr 28, 2026
@bors
Auto merge of #152443 - kjetilkjeka:nvptx_drop_support_old_hw_and_isa…
d04106d 
…, r=ZuseZ4

NVPTX: Drop support for old architectures and old ISAs



This is the implementation of [this MCP](rust-lang/compiler-team#965 (comment))

I believe it was said that no FCP was needed, but if that is incorrect then the FCP is anyway scheduled to finish in 2 days so it can in any case be merged then.
@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

rust-log-analyzer commented Apr 29, 2026

The job dist-loongarch64-musl failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 29, 2026

💔 Test for d04106d failed: CI. Failed job:

@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Apr 29, 2026

@bors retry (timeout)

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2026
@ShoyuVanilla ShoyuVanilla mentioned this pull request Apr 29, 2026
Merged
@jieyouxu
Copy link
Copy Markdown
Member

jieyouxu commented Apr 29, 2026 •
edited
Loading

Let us know if loongarch job still fails with insufficient disk space in #t-infra > loongarch-musl job running out of disk space.

rust-bors Bot pushed a commit that referenced this pull request Apr 29, 2026
@bors
Auto merge of #155953 - ShoyuVanilla:rollup-BrmB2HL, r=ShoyuVanilla
4f9e4e1 
Rollup of 6 pull requests

Successful merges:

 - #152443 (NVPTX: Drop support for old architectures and old ISAs)
 - #155648 (`-Znext-solver` Propagate `stalled_on_coroutines` as a field in `Certainty::Maybe`)
 - #155896 (Shrink `ParseSess`)
 - #155922 (delete unused auxiliary test files)
 - #155943 (fix: ✏️ forgot to change the stable version for `assert_matches!` macro.)
 - #155947 (tests: mark simple UI tests as check-pass)
@rust-bors rust-bors Bot merged commit 5d26634 into rust-lang:main Apr 29, 2026
12 of 13 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 29, 2026
rust-timer added a commit that referenced this pull request Apr 29, 2026
@rust-timer
Unrolled build for #152443
4a9b0a8 
Rollup merge of #152443 - kjetilkjeka:nvptx_drop_support_old_hw_and_isa, r=ZuseZ4

NVPTX: Drop support for old architectures and old ISAs

This is the implementation of [this MCP](rust-lang/compiler-team#965 (comment))

I believe it was said that no FCP was needed, but if that is incorrect then the FCP is anyway scheduled to finish in 2 days so it can in any case be merged then.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZuseZ4 ZuseZ4 ZuseZ4 left review comments

Assignees

@ZuseZ4 ZuseZ4

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. O-NVPTX Target: the NVPTX LLVM backend for running rust on GPUs, https://llvm.org/docs/NVPTXUsage.html S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.97.0

Development

Successfully merging this pull request may close these issues.

8 participants

@kjetilkjeka @rustbot @rust-log-analyzer @ZuseZ4 @CodesInChaos @jhpratt @jieyouxu @jackh726