Update unexpected_cfgs lint for Cargo new check-cfg config#125219
Merged
bors merged 6 commits intorust-lang:masterfrom May 20, 2024
Merged
Update unexpected_cfgs lint for Cargo new check-cfg config#125219bors merged 6 commits intorust-lang:masterfrom
unexpected_cfgs lint for Cargo new check-cfg config#125219bors merged 6 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the diagnostics output of the
unexpected_cfgslint for Cargo newcheck-cfgconfig.It's a simple and cost-less alternative to the build-script
cargo::rustc-check-cfginstruction.This PR also adds a Cargo specific section regarding check-cfg and Cargo inside rustc's book (motivation is described inside the file, but mainly check-cfg is a rustc feature not a Cargo one, Cargo only enabled the feature, it does not own it; T-cargo even considers the
check-cfglint config to be an implementation detail).This PR also updates the links to refer to that sub-page when using Cargo from rustc.
As well as updating the lint doc to refer to the check-cfg docs.
Not to be merged before rust-lang/cargo#13913 reaches master!(EDIT: merged in #125237)@rustbot label +F-check-cfg
r? @fmease (feel free to roll)
Fixes #124800
cc @epage @weihanglo