Add network socket shutdown shim#4987
Conversation
|
Thank you for contributing to Miri! A reviewer will take a look at your PR, typically within a week or two. |
|
The CI fails for the same reason mentioned here: #4984 (comment). What would you suggest doing to handle such unknown I/O errors? |
There was a problem hiding this comment.
I didn't even know this operation exists.^^ I wonder what the point is, why wouldn't you just close?
Anyway, this mostly looks good, except for some test nits.
@rustbot author
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot ready |
There was a problem hiding this comment.
Just one final nit. :) Please also squash the commits.
@rustbot author
89b417b to
5e0971e
Compare
|
@rustbot ready |
Hi,
This pull request adds the shim for the
shutdownsyscall for TCP sockets.I've ran the tokio TCP tests using Miri and noticed that many of them require
TcpStream::shutdownso it would be nice to also have this shimmed.