fix(theme): sync theme selection across browser windows#3119
Open
leno23 wants to merge 1 commit into
Open
Conversation
Listen for localStorage `storage` events so other windows/tabs apply theme changes. When applying a theme, remove every known theme class from <html> instead of only the previous one, avoiding multiple theme classes stacking after cross-window updates. Fixes rust-lang#2618 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storageevents onmdbook-themeand apply changes in other tabs/windows<html>before adding the new one (not onlypreviousTheme)Motivation
With multiple mdBook tabs open, changing the theme in one window left others stale; stacked theme classes could also break rendering (#2618).
Test plan
cargo test --test testsuiteFixes #2618
Made with Cursor