fix(search): stop type-ahead search from polluting browser history#3118
Open
leno23 wants to merge 1 commit into
Open
fix(search): stop type-ahead search from polluting browser history#3118leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Updating the URL on each keypress used pushState for the first character, which polluted the browser history list. Always use replaceState while typing; Escape still uses push when closing a non-empty search so Back can restore the query. Fixes rust-lang#2635 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
history.replaceState(viasetSearchUrlParameters(..., 'replace')) on each keypress while searchingpushState, adding a history entry per new search session and cluttering the browser history listMotivation
Type-ahead search updated
?search=on every keystroke; even with replace for subsequent keys, the initialpushStateand URL churn created noisy history (#2635, reported by @ehuss).Test plan
cargo test --test testsuiteFixes #2635
Made with Cursor