fix(html): parse inline SVG with XML declarations (#3005)#3109
Open
leno23 wants to merge 1 commit into
Open
Conversation
Strip `<?xml ...?>` processing instructions before tokenizing HTML, and treat `<svg>` content as raw text like `<style>` so nested markup and PIs do not trigger html5ever parse warnings. Fixes rust-lang#3005 Co-authored-by: Cursor <cursoragent@cursor.com>
leno23
force-pushed
the
fix/svg-xml-decl-parse-3005
branch
from
e2e978d to
0d576bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes spurious
Saw ? in state TagOpenwarnings when books include inline SVG (e.g. from mdbook-d2) that contains XML processing instructions or nested markup.<?xml ...?>(and other<?...?>) before HTML tokenization — invalid in HTML but common in SVG output<svg>bodies as raw text (same approach as<style>/<script>), preserving nested tags without html5ever parse errorsFixes #3005
Test plan
cargo test -p mdbook-html parse_htmlcargo test -p mdbook-htmlMade with Cursor