fix(html): reserve toc.md and document toc.html#3108
Open
leno23 wants to merge 1 commit into
Open
Conversation
Reject src/toc.md chapters so they cannot overwrite generated toc.html. Document toc.html and the reserved toc.md name. Fixes rust-lang#3090. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
CI is green (15/15). Implements the reserve- |
Author
|
Closing as duplicate of #3094, which already reserves |
Author
|
Reopening — CI was 15/15 green; closed by mistake. Ready for review (fixes #3090). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3090.
toc.md(same mechanism asprint.md) so they cannot overwrite auto-generatedtoc.htmltoc.htmland reservedtoc.mdin the HTML renderer configuration guideno_reserved_toc_filenameintegration testTest plan
cargo test no_reserved_toc_filenamecargo test no_reserved_filename(existing print.md test unchanged)Related: #3107 documents
print.md/print.htmlseparately.Made with Cursor