feat(html): include line numbers in unclosed HTML tag warnings#3096
Open
leno23 wants to merge 1 commit into
Open
feat(html): include line numbers in unclosed HTML tag warnings#3096leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
Use pulldown-cmark's offset iterator to record where raw HTML tags open and report both the opening line and the exit line when a markdown element ends with unclosed tags. Fixes rust-lang#3079 Co-authored-by: Cursor <cursoragent@cursor.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pulldown-cmark'sinto_offset_iter()when building the HTML tree so raw HTML tags record their opening line in the source markdown.Example warning:
Fixes #3079.
Test plan
cargo test -p mdbook-htmlcargo test -p mdbook unclosed_htmlunclosed_html_tags_line_numbersintegration test for multi-line markdownMade with Cursor