Skip to content

ci: add target explicitly for i686-unknown-freebsd#5064

Closed
xtqqczze wants to merge 1 commit intorust-lang:mainfrom
xtqqczze:GH5058
Closed

ci: add target explicitly for i686-unknown-freebsd#5064
xtqqczze wants to merge 1 commit intorust-lang:mainfrom
xtqqczze:GH5058

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@rustbot rustbot added A-CI Area: CI-related items S-waiting-on-review labels Apr 17, 2026
Copy link
Copy Markdown
Contributor

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with the current code? rustup target add x86_64-unknown-freebsd is a no-op if that's the host. It doesn't cost anything to run.

View changes since this review

@xtqqczze
Copy link
Copy Markdown
Contributor Author

It just adds unnecessary noise to the logs, and I prefer keeping it explicit.

@JohnTitor
Copy link
Copy Markdown
Member

I feel it won't disturb anyone when checking logs: https://github.com/rust-lang/libc/actions/runs/24514392672/job/71789027802#step:3:378

I'd prefer simplicity over preciseness.

@xtqqczze xtqqczze closed this Apr 17, 2026
@xtqqczze xtqqczze deleted the GH5058 branch April 17, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: CI-related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants