Skip to content

docs: prepare changelog for git2@0.21.0#1248

Open
weihanglo wants to merge 2 commits into
rust-lang:mainfrom
weihanglo:git2-changelog-0.21.0
Open

docs: prepare changelog for git2@0.21.0#1248
weihanglo wants to merge 2 commits into
rust-lang:mainfrom
weihanglo:git2-changelog-0.21.0

Conversation

@weihanglo
Copy link
Copy Markdown
Member

This is just a changelog update. For the actual publish, we are still waiting for some other changes like #1206 and probably #1241

weihanglo added 2 commits May 7, 2026 23:19
Release date will be finalized later before publish
@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label May 8, 2026
@weihanglo
Copy link
Copy Markdown
Member Author

@DanielEScherzer, since you have contributed tons of PRs in this release, do you want to help check if anything I misplaced/misunderstood?

Comment thread CHANGELOG.md

### Added

- Added `opts::set_cache_max_size` and `opts::get_cached_memory`.
Copy link
Copy Markdown
Contributor

@DanielEScherzer DanielEScherzer May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I suggest that names of functions have () with them?

View changes since the review

Comment thread CHANGELOG.md

- Fixed `MergeOptions::skip_reuc` to use the correct `GIT_MERGE_SKIP_REUC` flag.
[#1194](https://github.com/rust-lang/git2-rs/pull/1194)
- `Repository::submodules` now returns an error from libgit2 instead of asserting.
Copy link
Copy Markdown
Contributor

@DanielEScherzer DanielEScherzer May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

returns an error under what conditions? Instead of asserting what? And the issue wasn't the assertion, but rather that it failed. Maybe (assuming I understand the previous behavior)

Repository::submodules() now returns an Error when the underlying git_submodule_lookup() call to libgit2 fails, rather than panicking with a failed assertion.

View changes since the review

Comment thread CHANGELOG.md
[#1198](https://github.com/rust-lang/git2-rs/pull/1198)
- Bumped `time` from 0.3.41 to 0.3.47.
[#1215](https://github.com/rust-lang/git2-rs/pull/1215)
- Removed the flaky `email_env_var` test.
Copy link
Copy Markdown
Contributor

@DanielEScherzer DanielEScherzer May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a change to drop a test that was added in a previous patch that is also included in the same release, so I don't think we need to mention it here since the test doesn't exist on 0.20.4, but just a thought

View changes since the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Waiting on review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants