docs: prepare changelog for git2@0.21.0#1248
Conversation
Release date will be finalized later before publish
|
@DanielEScherzer, since you have contributed tons of PRs in this release, do you want to help check if anything I misplaced/misunderstood? |
|
|
||
| ### Added | ||
|
|
||
| - Added `opts::set_cache_max_size` and `opts::get_cached_memory`. |
There was a problem hiding this comment.
can I suggest that names of functions have () with them?
|
|
||
| - Fixed `MergeOptions::skip_reuc` to use the correct `GIT_MERGE_SKIP_REUC` flag. | ||
| [#1194](https://github.com/rust-lang/git2-rs/pull/1194) | ||
| - `Repository::submodules` now returns an error from libgit2 instead of asserting. |
There was a problem hiding this comment.
returns an error under what conditions? Instead of asserting what? And the issue wasn't the assertion, but rather that it failed. Maybe (assuming I understand the previous behavior)
Repository::submodules()now returns anErrorwhen the underlyinggit_submodule_lookup()call to libgit2 fails, rather than panicking with a failed assertion.
| [#1198](https://github.com/rust-lang/git2-rs/pull/1198) | ||
| - Bumped `time` from 0.3.41 to 0.3.47. | ||
| [#1215](https://github.com/rust-lang/git2-rs/pull/1215) | ||
| - Removed the flaky `email_env_var` test. |
There was a problem hiding this comment.
this is a change to drop a test that was added in a previous patch that is also included in the same release, so I don't think we need to mention it here since the test doesn't exist on 0.20.4, but just a thought
This is just a changelog update. For the actual publish, we are still waiting for some other changes like #1206 and probably #1241