Skip to content

Remove curl dependency from crates-io crate #16936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arlosi wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove curl dependency from crates-io crate #16936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9470d36
Add timeout to request_blocking
arlosi Apr 21, 2026
8836d77
Only set upload when the body has non-zero length
arlosi Apr 23, 2026
e34a323
Add enum for crates.io token errors
arlosi Apr 23, 2026
4e8670d
Add non_exhaustive to Error enum
arlosi Apr 23, 2026
54ea404
Convert crates-io crate to use http_async
arlosi Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ clap = "4.6.0"
clap_complete = { version = "4.6.0", features = ["unstable-dynamic"] }
color-print = "0.3.7"
core-foundation = { version = "0.10.1", features = ["mac_os_10_7_support"] }
crates-io = { version = "0.40.20", path = "crates/crates-io" }
crates-io = { version = "0.41.0", path = "crates/crates-io" }
criterion = { version = "0.8.2", features = ["html_reports"] }
curl = "0.4.49"
curl-sys = "0.4.87"
Expand Down
4 changes: 2 additions & 2 deletions crates/crates-io/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "crates-io"
version = "0.40.20"
version = "0.41.0"
rust-version = "1.95" # MSRV:1
edition.workspace = true
license.workspace = true
Expand All @@ -14,7 +14,7 @@ name = "crates_io"
path = "lib.rs"

[dependencies]
curl.workspace = true
http.workspace = true
Copy link
Copy Markdown
Member

@weihanglo weihanglo Apr 24, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we enhance docs talking about how to restore the curl backend behavior?

If it is not worthy, leave it :)

View changes since the review

Copy link
Copy Markdown
Contributor Author

@arlosi arlosi Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm kinda split about that. I have a branch that adds a curl feature to provide a CurlClient that implements the trait and gives users a way back to the old behavior. However, since Cargo wouldn't be enabling the feature, it would have less coverage.

percent-encoding.workspace = true
serde = { workspace = true, features = ["derive"] }
serde_json.workspace = true
Expand Down
Loading