Skip to content

events: add gallery msgtype for MSC4274#2044

Merged
zecakeh merged 10 commits intoruma:mainfrom
Johennes:johannes/inline-galleries
Mar 20, 2025
Merged

events: add gallery msgtype for MSC4274#2044
zecakeh merged 10 commits intoruma:mainfrom
Johennes:johannes/inline-galleries

Conversation

@Johennes
Copy link
Copy Markdown
Contributor

This adds the gallery msgtype from MSC4274.

Comment thread crates/ruma-events/src/room/message/content_serde.rs Outdated
@Johennes Johennes marked this pull request as ready for review March 18, 2025 19:40
Comment thread crates/ruma-events/src/room/message.rs
Copy link
Copy Markdown
Contributor

@zecakeh zecakeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an entry in the changelog

Comment thread crates/ruma/Cargo.toml
Comment thread crates/ruma-events/src/room/message/content_serde.rs Outdated
Copy link
Copy Markdown
Contributor

@zecakeh zecakeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the extra test request, this looks good!

Comment thread crates/ruma-events/tests/it/room_message.rs
Comment thread crates/ruma-events/src/room/message/audio.rs
Copy link
Copy Markdown
Contributor

@zecakeh zecakeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants