Repository navigation
feat(player): show playback source pill - #1493
Open
Deathemonic wants to merge 2 commits into
Open
Deathemonic wants to merge 2 commits into
Deathemonic wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Before submitting a pull request, you must attest to the following:
Summary
Add a pill to the player to indicate what source it's playing. Its especially useful when using modules.
Linked Work
Change Type
Affected Surfaces
:app:core:lyrics:lastfm:canvas:shazamkit:spotifycoreScreenshots / Recordings
Working demo here
Behavior Notes
settings/modules?moduleId=...for a module, or player settings otherwise.Architecture Checklist
Loading,Success,Empty, andErrorwhere this PR introduces or changes screen state.runBlockingis introduced in app execution paths.Compose / Material Checklist
collectAsStateWithLifecycle().@Immutableor@Stable.keyvalues and explicitcontentType.derivedStateOfwhere appropriate.stringResource()and duplicated visible strings on the same screen are avoided.WindowInsetscorrectly when this PR changes screen layout.Concurrency / Performance Checklist
viewModelScopeor an existing lifecycle-owned application/service scope.Dispatchers.IOorDispatchers.Default.Data / Persistence Checklist
app/schemas.Playback / Integration Checklist
universal,arm64,armeabi,x86, andx86_64variants.Localization / Assets Checklist
Privacy / Security Checklist
Verification
Reviewer Focus
ModulePlaybackSourceRepositoryandObserveModulePlaybackSourceUseCase: how the Hidden / Loading / YouTube / Module states are derived.ModuleSourceTimeRow: replaces the hand-rolled time rowsModuleSettingsViewModel: readsmoduleIdfromSavedStateHandleto open a specific module.Release Notes
Added a source pill to the player that shows whether a track is playing from a module or YouTube.