[Deathemonic]

Pull Request

Before submitting a pull request, you must attest to the following:

• This pull request complies with ArchiveTune's NO AI / NO LLM POLICY.

Summary

Replace the Spotify PNG with a vector drawable (spotify.xml) and update all references to it. This fixes the icon scaling in Settings > Integrations.

Linked Work

• Closes:
• Related:

Change Type

• Feature
• Bug fix
• UI / UX
• Performance / memory
• Playback / Media3
• Lyrics / provider integration
• Search / YouTube / network data
• Local library / Room database
• Widgets / notification / shortcuts
• Settings / preferences / DataStore
• Discord / Last.fm / ListenBrainz / external integration
• Localization / strings / fastlane metadata
• Build / Gradle / CI / release packaging
• Dependency update
• Documentation only

Affected Surfaces

• :app
• :core
• :lyrics
• :lastfm
• :canvas
• :shazamkit
• :spotifycore
• Other:

Screenshots / Recordings

Before	After

Behavior Notes

No behavior changes

Architecture Checklist

• The change preserves UDF flow: UI -> ViewModel -> UseCase/domain -> Repository/data.
• Screen state is represented structurally with Loading, Success, Empty, and Error where this PR introduces or changes screen state.
• Composables receive immutable, UI-specific domain models instead of raw Room, network, or service entities.
• Business work is not triggered directly from composition.
• Exceptions are surfaced through explicit state or result types instead of being swallowed.
• No runBlocking is introduced in app execution paths.

Compose / Material Checklist

• UI state is hoisted out of composable layout code.
• Reactive state is collected with collectAsStateWithLifecycle().
• New UI models are annotated with @Immutable or @Stable.
• Lazy layouts use stable key values and explicit contentType.
• Non-primitive constants, structural lambdas, and allocation-heavy objects in hot paths are remembered.
• Rapidly changing inputs such as scroll, gesture, animation, or playback progress use derivedStateOf where appropriate.
• UI strings come from stringResource() and duplicated visible strings on the same screen are avoided.
• Interactive elements keep a minimum 48dp touch target.
• Material 3 / Material 3 Expressive tokens are used for color, typography, shape, and motion instead of hardcoded UI values.
• Edge-to-edge layouts handle and consume WindowInsets correctly when this PR changes screen layout.

Concurrency / Performance Checklist

• Business coroutines are scoped to viewModelScope or an existing lifecycle-owned application/service scope.
• Disk, database, network, parsing, and heavy mapping work is dispatched to Dispatchers.IO or Dispatchers.Default.
• Cancellation is handled explicitly where long-running work, playback, downloads, sync, lyrics fetching, or recognition is involved.
• The change avoids blocking the main thread.
• The change avoids unnecessary allocations in recomposition loops, playback loops, polling loops, and provider parsing paths.
• Large lists, images, lyrics payloads, and network responses are bounded, streamed, cached, paged, or mapped off the main thread as appropriate.

Data / Persistence Checklist

• Room entity, DAO, or database changes include a schema update under app/schemas.
• Database migrations preserve existing user data and fail clearly when migration is impossible.
• DataStore or preference-key changes are backward compatible.
• Network DTOs remain isolated from UI models.
• Provider responses handle missing, malformed, regional, or rate-limited data without crashing the app.

Playback / Integration Checklist

• Media3 playback, queue, cache, and service behavior remains stable across foreground, background, notification, and process recreation paths.
• Audio focus, notification controls, widgets, shortcuts, and media session actions are considered when playback behavior changes.
• External integrations handle absent credentials, revoked auth, network failure, and API changes.
• Native, AAR, or ABI-sensitive changes account for mobile/tv and universal, arm64, armeabi, x86, and x86_64 variants.

Localization / Assets Checklist

• User-facing strings are added to the base resources and translated resources are updated or intentionally left for translation follow-up.
• Unused string resources, drawables, and metadata are removed when replaced.
• Image assets have explicit display dimensions and are decoded at the displayed size.
• Fastlane metadata, screenshots, icons, or release text are updated when user-facing store behavior changes.

Privacy / Security Checklist

• No secrets, keys, tokens, keystores, signing files, private certificates, or local machine paths are committed.
• Logs do not expose access tokens, cookies, auth headers, user identifiers, listening history, or local file paths.
• New network calls are justified by the feature and use existing client, proxy, timeout, and error-handling patterns.
• User data remains local unless the PR explicitly documents the integration and consent path.

Verification

• Android Studio sync: Gradle sync completes without errors
• Manual device/emulator verification: Opened Settings > Integrations on physical device and confirmed the Spotify icon now renders at the correct size
• UI screenshot/recording attached: Before/after screenshots in the table above
• Accessibility or touch-target review: N/A
• Regression areas checked: N/A
• CI expectation: Build should pass

Reviewer Focus

• app/src/main/res/drawable/spotify.xml: new 24dp vector, white fill, relies on Icon tinting.
• Icon references changed in IntegrationScreen, CanvasSettings, LibraryScreen, LibraryMixScreen, SpotifyLibraryItems, and SpotifyLikedSongsScreen. These are rename-only changes.

Release Notes

Fixed the Spotify icon scaling in Settings > Integrations and made it crisp everywhere else it appears.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-22T05:04:36.649771Z We couldn’t complete this review. Comment @codex review to try again.	de348f6	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.