Repository navigation
Local library and player updates and some minor performance fixes - #1480
Open
TahaNacibe wants to merge 100 commits into
Open
TahaNacibe wants to merge 100 commits into
TahaNacibe wants to merge 100 commits into
Conversation
…ansfer for cast Refs: rukamori#1391
…outine flow imports Refs: rukamori#1391 rukamori#1409
…blocking resolver method
…improve mime type detection
…r content padding Refs: rukamori#1418
…roblems i usually don't work much on kotline that's why i didn't wanna contribute but i had enough time to learn it and check the code base by now so the changes i made are all in a localy saved branche i experiment in and i tested the features everything work, most of the changes wre for local filels because i do use that more: changed the local library filters adding ordering by adding date and played count and pllaying total time, made the default state of the added newly start by the new, added local library to the quick tabs of the library and extended main search to also search localy, in local player added caching to next and previuse song to avoid having to wait it to laod, also changed it for a smoother change generally if you change songs in app quicklly sometimes it start the song session change ui for the next yet since session start late it fail to tarminate and start the new one you get next song ui with previuse one fixed that by forcing session start to wait for user interaction to stop, added a new seek bar type waves show the sounds intensity very usufull for when you look for a specific part or moving around then checking time, for download extended the logic to let user select download path also added deleting local items from app added downloading fulll queue (yes wierd but trust had 5 people ask for it which is not much but) added closing button for the player on the widget because some android phones had it stuck there forever (mine included) also there was bug in the local files scanning it was enttirly ignoring the settings both on items length and paths to scan even with these set it did not respect them fixed by forcing looking to work only under these condetions. NOTE:please ignore any typos you find here english not my first language but i'm not that bad in it, it's just my keyboards keys are going bad and some letters get typed many times) EXTRA NOTE: the code didn't work until i used jdk 21 so i updated the md file from 17 to 21 if that's okay pls check and confirm
…roblems i usually don't work much on kotline that's why i didn't wanna contribute but i had enough time to learn it and check the code base by now so the changes i made are all in a localy saved branche i experiment in and i tested the features everything work, most of the changes wre for local filels because i do use that more: changed the local library filters adding ordering by adding date and played count and pllaying total time, made the default state of the added newly start by the new, added local library to the quick tabs of the library and extended main search to also search localy, in local player added caching to next and previuse song to avoid having to wait it to laod, also changed it for a smoother change generally if you change songs in app quicklly sometimes it start the song session change ui for the next yet since session start late it fail to tarminate and start the new one you get next song ui with previuse one fixed that by forcing session start to wait for user interaction to stop, added a new seek bar type waves show the sounds intensity very usufull for when you look for a specific part or moving around then checking time, for download extended the logic to let user select download path also added deleting local items from app added downloading fulll queue (yes wierd but trust had 5 people ask for it which is not much but) added closing button for the player on the widget because some android phones had it stuck there forever (mine included) also there was bug in the local files scanning it was enttirly ignoring the settings both on items length and paths to scan even with these set it did not respect them fixed by forcing looking to work only under these condetions. NOTE:please ignore any typos you find here english not my first language but i'm not that bad in it, it's just my keyboards keys are going bad and some letters get typed many times) EXTRA NOTE: the code didn't work until i used jdk 21 so i updated the md file from 17 to 21 if that's okay pls check and confirm Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… resolution and open podcast shows from media links rukamori#1448 Co-authored-by: mikooochi <89002922+mikooochi@users.noreply.github.com>
…g by album (fixes rukamori#1412) (rukamori#1468) Co-authored-by: morieeattonkatsu <107134739+rukamori@users.noreply.github.com>
…m scrobbler (fixes rukamori#1445) (rukamori#1467) Co-authored-by: morieeattonkatsu <107134739+rukamori@users.noreply.github.com>
…ith blank lines (rukamori#1463) Co-authored-by: morieeattonkatsu <107134739+rukamori@users.noreply.github.com>
…ri#1317) (rukamori#1469) Co-authored-by: morieeattonkatsu <107134739+rukamori@users.noreply.github.com>
…nded (fixes rukamori#1197) (rukamori#1466) Co-authored-by: morieeattonkatsu <107134739+rukamori@users.noreply.github.com>
Co-authored-by: mikooochi <89002922+mikooochi@users.noreply.github.com>
TahaNacibe
force-pushed
the
fix/archive-tune-changes
branch
from
October 21, 2026 20:41
27fc05a to
9946127
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i usually don't work much on kotline that's why i didn't wanna contribute but i had enough time to learn it and check the code base by now so the changes i made are all in a locally saved branches i experiment in and i tested the features everything work, most of the changes were for local files because i do use that more:
EXTRA NOTE: the code didn't work until i used JDK 21 so i updated the md file from 17 to 21 if that's okay pls check and confirm
EXTR NOTE AGAIN: i removed the star project dialog because each build deleted the saved state and kept bugging me so pls be aware of that if merging
(0u0) Thank you for making such a great app
Pull Request
Before submitting a pull request, you must attest to the following:
<<<<<<< HEAD
=======
Summary
Linked Work
Change Type
Affected Surfaces
:app:core:lyrics:lastfm:canvas:shazamkit:spotifycoreScreenshots / Recordings
Behavior Notes
local songs change now do not cause the sudden snap on switching nor the app now show previous trucks while playing next ones rest of changes follow same already set flow and behavior also now app cache next and previous truck for smoother movement
Architecture Checklist
Loading,Success,Empty, andErrorwhere this PR introduces or changes screen state.runBlockingis introduced in app execution paths.Compose / Material Checklist
collectAsStateWithLifecycle().@Immutableor@Stable.keyvalues and explicitcontentType.derivedStateOfwhere appropriate.stringResource()and duplicated visible strings on the same screen are avoided.WindowInsetscorrectly when this PR changes screen layout.Concurrency / Performance Checklist
viewModelScopeor an existing lifecycle-owned application/service scope.Dispatchers.IOorDispatchers.Default.Data / Persistence Checklist
app/schemas.Playback / Integration Checklist
universal,arm64,armeabi,x86, andx86_64variants.Localization / Assets Checklist
Privacy / Security Checklist
Verification
Reviewer Focus
Release Notes