Propagate response inflater finish errors - #344
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-local returns inside the inflater block bypass Zlib::Inflate#finish, suppressing truncation and other finalization errors after body reads. Restructure the branches to leave the block normally so inflater finalization always runs, while retaining chunked, fixed-length and EOF body behavior. Valid gzip data still succeeds and truncated 8, 12 and 20-byte inputs now raise Zlib::BufError; destination exceptions remain primary. The unchanged current suite passes 201 tests / 914 assertions on Ruby 4.0.6 and 199 / 906 on Ruby 3.2.11. External dual-Ruby inflater models, syntax and diff checks pass. No repository tests were changed.