Preserve streaming response destinations with body encoding - #338
Open
OskarEichler wants to merge 1 commit into
Open
Preserve streaming response destinations with body encoding#338OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Net::HTTPResponse#read_body supports an IO-like destination, but configured response body encoding currently assumes that destination is a String and calls String-only encoding methods after streaming completes. This raises for valid streaming destinations. Only run encoding detection or forcing when the destination responds to force_encoding. String bodies retain existing behavior and IO-like destinations keep the bytes already streamed. The unchanged current suite passes 201 tests / 914 assertions on Ruby 4.0.6 and 199 / 906 on Ruby 3.2.11. External dual-Ruby behavior models, syntax and diff checks pass. No repository tests were changed.