Close and unlink multipart temporary files on all exits - #331
Open
OskarEichler wants to merge 1 commit into
Open
Close and unlink multipart temporary files on all exits#331OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use block-scoped Tempfile.create for non-chunked multipart encoding so the temporary file is closed and unlinked on encoding, header-write and body-copy errors as well as success.
Reproduction
Create a multipart POST with a fixed boundary and use a BufferedIO whose write method raises IOError. Retain a reference to the generated temporary file and direct TMPDIR to an owned temporary directory. Before, the file remains open and present after the exception; afterward it is closed and removed without waiting for GC.
Verification
bundle exec rake test: 201 tests, 914 assertions, zero failures/errors, both baseline and this isolated patch.git diff --checkpass. Supplemental Lint scan retains the same 25 pre-existing findings; no new findings by file/cop.Compatibility and limitations
No API, wire-format or dependency change. Tempfile.create is available within the existing Ruby >= 2.7 requirement. Verification is on macOS; Windows filesystem semantics were not exercised.
Based on master
23e859e92e10e43cad520fcacac3fd43640dba7b. Optional external OpenSSL tests and other Ruby/OS combinations were not run. Existing related issues/PRs were checked; this is a focused correctness change, not a claim of exhaustive coverage.