Detect response byte-order marks independently of string encoding - #327
Open
OskarEichler wants to merge 1 commit into
Open
Detect response byte-order marks independently of string encoding#327OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compare BOM bytes with getbyte so detection does not depend on the String encoding tag. Preserve the supported UTF-16BE, UTF-16LE and UTF-8 signatures and leave the body bytes untouched.
Reproduction
Net::HTTPOK.new('1.1', '200', 'OK').send(:check_bom, ['feff0061'].pack('H*'))returns nil before this change and Encoding::UTF_16BE afterward. The corresponding fffe and efbbbf signatures reproduce the same issue. Actual response bodies arrive as binary strings.Verification
bundle exec rake test: 201 tests, 914 assertions, zero failures/errors, both baseline and this isolated patch.git diff --checkpass. Supplemental Lint scan retains the same 25 pre-existing findings; no new findings by file/cop.Compatibility and limitations
No API or dependency change. Automatic body encoding now recognizes these existing supported BOMs in binary responses. UTF-32 detection is outside this patch.
Based on master
23e859e92e10e43cad520fcacac3fd43640dba7b. Optional external OpenSSL tests and other Ruby/OS combinations were not run. Existing related issues/PRs were checked; this is a focused correctness change, not a claim of exhaustive coverage.