Skip to content

fix(tracking): honor disabled collection - #3317

Open
Agistaris wants to merge 1 commit into
rtk-ai:developfrom
Agistaris:fix/tracking-disable-persistence
Open

fix(tracking): honor disabled collection#3317
Agistaris wants to merge 1 commit into
rtk-ai:developfrom
Agistaris:fix/tracking-disable-persistence

Conversation

@Agistaris

Copy link
Copy Markdown

Summary

  • Honor tracking.enabled = false and RTK_TRACK=0 before opening the history database on normal, passthrough, parse-failure, and consented-telemetry paths.
  • Preserve the existing enabled-by-default behavior when configuration cannot be loaded.
  • Add a disposable binary regression covering configuration disablement, environment override, parse failure, and the enabled control.

Test plan

  • cargo fmt --all -- --check
  • cargo clippy --all-targets
  • cargo test --test tracking_disabled_test
  • Complete Cargo test matrix

The focused binary regression passes 1/1. Disabled cases create no history.db; the enabled control creates it normally. The complete Cargo matrix accounts for 2,584 tests: 2,576 passed, 8 ignored, and 0 failed.

@Agistaris
Agistaris marked this pull request as ready for review July 30, 2026 09:43
@CLAassistant

CLAassistant commented Jul 30, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants