fix(git): honor status_max_files and status_max_untracked (#3296) - #3311
Open
NanoRisk6 wants to merge 1 commit into
Open
fix(git): honor status_max_files and status_max_untracked (#3296)#3311NanoRisk6 wants to merge 1 commit into
NanoRisk6 wants to merge 1 commit into
Conversation
limits.status_max_* lived in config but format_status ignored them, so large repos printed the full porcelain list. Cap tracked and untracked entries separately and surface overflow counts so monorepo status stays compact under configured limits.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
[limits].status_max_filesandstatus_max_untrackedin RTK config were never applied.rtk git statusprinted the full porcelain list on large WIP monorepos, so the highest-volume git command skipped the configured compaction. Fixes #3296.Why This Change Was Made
format_status_innernow caps tracked changes and untracked entries separately usingconfig::limits(), and appends an overflow line (... +N more changed/untracked) when truncated. Tests can pass unlimited caps for the full-path recovery case.User Impact
Large repos respect
status_max_files/status_max_untracked(defaults 15 / 10). Agents and humans get compact status with an explicit remainder count instead of a wall of paths.Evidence