fix(git): preserve trailing newline on status --short/--porcelain (#3303) - #3307
Open
NanoRisk6 wants to merge 1 commit into
Open
fix(git): preserve trailing newline on status --short/--porcelain (#3303)#3307NanoRisk6 wants to merge 1 commit into
NanoRisk6 wants to merge 1 commit into
Conversation
…k-ai#3303) Non-compact status used join + print!, dropping the final newline so shell pipelines and read loops missed the last entry.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
rtk git status --short/--porcelainfiltered output was emitted withprint!afterjoin("\n"), so the final entry had no trailing newline. That breakswhile readloops and glues the last line to following output. Fixes #3303.Why This Change Was Made
Print status output with a trailing newline when the filtered file list is non-empty, matching native
git status --short/--porcelainbehavior.User Impact
Scripts and agent parsers that read status line-by-line work correctly again.
Evidence