Docker: consumer default stack, env disk sources, persisted config - #122
Merged
Conversation
Member
Author
…nd InitSourceConfigs hardening Rework Compose so the baked-image consumer install is default (persisted MySQL/config, optional demo sources), add dev compose and interactive .env + rebuild-consumer helpers, extend write-config/seed with LOGANALYZER_DISK_* sources and DiskAllowed, and tighten InitSourceConfigs so empty or invalid DB sources/DefaultSourceID no longer fatals pages that load sources early. Publish GHCR image on tag v* workflow; handbook/README/AGENTS/docker README updated; E2E smoke/screenshot tweaks for the new bootstrap. Validation: Not run here ( PHPUnit / compose / Playwright not executed in this handoff ).
Member
Author
There was a problem hiding this comment.
Code Review
This pull request overhauls the Docker deployment by introducing multi-stage builds, interactive environment setup scripts, and specialized Compose stacks for development and E2E testing. It also adds support for dynamic disk source configuration via environment variables and improves application robustness with enhanced safety checks and refactored configuration logic. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
docker-compose.yml): baked app, named volumes for MySQL + generatedconfig.php, clean install unlessLOGANALYZER_SEED_SAMPLE_SOURCESorLOGANALYZER_DISK_*seeds sources on first run; dev/E2E compose paths and scripts aligned.docker/env-disk-sources.php,LOGANALYZER_DISK_SOURCE_PATHS/LOGANALYZER_DISK_SOURCES/LOGANALYZER_DISK_ALLOWED_EXTRA) wirewrite-config+seed-database;docker/env.example,init-env-interactive, andrebuild-consumersupport repo-root.env.InitSourceConfigsand related entry pages avoid fatal paths when there are no valid sources or a staleDefaultSourceID/session.docker/README.mdand cross-links across handbook index,docker.md, README/project-readme,quick-start,AGENTS.md; new.github/workflows/docker-publish.ymlforghcr.ioon version tags.