Repository navigation
test: Update #green screenshots for Chrome 156 - #455
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's new runner images (
20261021) update Google Chrome from 155 to 156. Chrome 156 captures the 100px × 100px#greenbox intest-app-image.Ras 100 × 100; Chrome 155 cut it to 99 × 100.compare_screenshot_threshold()fails when sizes differ, so both "screenshot can be expected" tests fail onmainon the new image (Ubuntu and Windows).This updates
app-image/screen1-001.pngandscreen2-001.pngto the 100 × 100 snapshots frommain's CI run (downloaded withtestthat::snapshot_download_gh(); the Ubuntu and Windows snapshots match pixel for pixel). A newskip_if_chrome_older_than(app, 156)helper inhelper-skip-if.Rskips both tests on older Chrome, so machines still on the old runner image or a local Chrome 155 don't fail.Checked locally on Chrome 155: the rest of
test-app-image.Rpasses and both screenshot tests are skipped with "Chrome 155 is older than 156".