Repository navigation
Conversation
schloerke
enabled auto-merge (squash)
October 21, 2026 17:49
…g them pak reads rules from r-hub/r-system-requirements, which doesn't have rstudio/r-system-requirements#270 yet. Read them from upstream, so pak skips the Launchpad Chromium install when Chrome is already on the runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451.
dev_pkg_path()usedpkgload::pkg_path(), which also matches installed packages because they have aDESCRIPTIONfile. When tests run viatestthat::test_package(), the working directory is inside the installed package, soAppDriverreplacedlibrary(<pkg>)withpkgload::load_all()on the installed folder and got an empty namespace.dev_pkg_path()now returnsNULLwhenMeta/package.rdsexists (only installed packages have it), anddev_pkg_name()followsdev_pkg_path(). The reprex from the issue fails before this change and passes after; new tests are intests/testthat/test-pkg.R.CI: Linux jobs were failing because pak added the
ppa:xtradeb/appsLaunchpad PPA to install Chromium, and the PPA often returns503. rstudio/r-system-requirements#270 skips that install when Chrome is already present, but pak reads its rules from r-hub/r-system-requirements, which doesn't have it yet..github/shiny-workflows/package-install.shandtest-actions.yamlsetR_PKG_SYSREQS_GIT_REPO_URLso pak reads the upstream rules. TODO: remove both once r-hub/r-system-requirements#4 is merged.