Repository navigation
Replace rLogin with Reown AppKit - #573
jessgusclark wants to merge 99 commits into
Conversation
* fix: fix decentralized url issue * fix: fix delete already set decentralized url * fix: lint fix --------- Co-authored-by: Sergio <sergio.jara@iovlabs.org>
* fix: fix bug related to search box * fix tests * fix CI
* fix: wip * feat: add new partner addresses * chore: lint * fix: change big number calculation lib * feat: updating testnet contract addresses * fix: use correct steps for subdomain setup * chore: remove redundant code --------- Co-authored-by: Anni Piragauta <anni.piragauta@iovlabs.org>
Co-authored-by: Maduabuchi Chinaechetam <cmaduabuchi@live.com>
* chore: update footer links * fix: remove unused vars
* fix: change error message when user rejects transaction
* Fix/subdomain flow ux improv (#534)
* fix: use js matching fn to exclude periods instead of complex regex
* fix: use better language to communicate expired domain next steps * test: disable outdated test * test: add new test
* fix: cosmetic issue with register button in Spanish * fix: fix CI/CD by updating snapshot * fix: error when language is set to English
* feat: add not enough RIF balance error message * fix: not allow revealing commit if there is no enough RIF balance * fix: remove unnecessary variables * fix: reducer initial state tests * refactor: rename error * refactor: format message * fix: error message for not enough rif balance responds to language change * fix: removing unnecessary imports * refactor: remove switch case for an object
Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64. - [Release notes](https://github.com/medikoo/es5-ext/releases) - [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md) - [Commits](medikoo/es5-ext@v0.10.62...v0.10.64) --- updated-dependencies: - dependency-name: es5-ext dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2. - [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md) - [Commits](browserify/browserify-sign@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: browserify-sign dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const projectId = process.env.REACT_APP_PROJECT_ID | ||
| || process.env.REACT_APP_WALLETCONNECT_PROJECT_ID | ||
| || ''; |
There was a problem hiding this comment.
AppKit is created with projectId pulled from environment variables but falls back to an empty string (lines 5‑7). Reown/WalletConnect clients reject initialization without a non-empty projectId, so on environments that haven’t been provisioned with REACT_APP_PROJECT_ID (none are defined in this repo), the login modal will throw at startup and users won’t be able to authenticate.
Useful? React with 👍 / 👎.
|
closing this PR. Codex created the branch from |
6 participants
Summary
Testing
Codex Task