Repository navigation
Fix rlogin issues - #570
jessgusclark wants to merge 12 commits into
Conversation
- It was a good idea, but the package was not maintained and creates tech debt now
There was a problem hiding this comment.
Pull request overview
This PR migrates from the unmaintained @rsksmart/rlogin-essentials package to using @rsksmart/rlogin directly, removing technical debt. Hardware wallet integrations (Trezor and Ledger) have been temporarily commented out and will be reintroduced later.
Key Changes:
- Replaced
rlogin-essentialswith direct@rsksmart/rloginimplementation - Added WalletConnect provider configuration
- Commented out hardware wallet provider integrations
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/rLogin/rLogin.js | Implements rLogin directly with custom provider configuration, removing essentials dependency |
| package.json | Updates dependencies to use @rsksmart/rlogin and @walletconnect/web3-provider instead of rlogin-essentials |
Comments suppressed due to low confidence (1)
package.json:1
- Corrected spelling of 'dependecy' to 'dependency' in PR description.
{
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Walletconnect was not working and that bridge URL is no longer working - remove second set of () around RLogin
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- There is no plans in the future to support dCent, so I'll remove this code for now
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }; | ||
|
|
||
| export default rLogin; | ||
| export default createRLogin(); |
There was a problem hiding this comment.
The createRLogin() function is called at module load time, which means the RLogin instance is created immediately when this module is imported. This could cause issues if environment variables change or if the module needs to be re-initialized. Consider exporting the factory function instead and calling it where needed, or document why immediate initialization is required.
| export default createRLogin(); | |
| export default createRLogin; |
- Add env item
GitHub Actions
Failure
GitHub Actions
Failure
GitHub Actions
Failure
GitHub Actions
Inactive
GitHub Actions
Inactive
|
|
Bumping web3modal did not solve the original issue of metamask mobile. Therefor closing this PR and will break out working parts into their own PRs. |
This PR removes the dependecy on rLogin-essentials and implements rLogin straight from the source. While the essentials package was a good idea, it wasn't maintained and has caused tech debt.
This PR also removes the hardware integrations which are not working on the main site. These will be added back in later.