Skip to content

resolver UI now hard-codes hasMulticoin to false聽#572

Description

@jessgusclark

馃挕 Codex Review

const hasAddr = supportedInterfaces.indexOf('addr') > -1;
const hasChainAddr = supportedInterfaces.indexOf('chainAddr') > -1;
const hasMulticoin = false;
const hasName = supportedInterfaces.indexOf('name') > -1;

P1 Badge Multicoin resolution always disabled

The resolver UI now hard-codes hasMulticoin to false, so even when the resolver advertises the multicoin interface it will be ignored and the chain address component will never render. Any resolver that only supports multicoin (and not chainAddr) will no longer expose cross-chain address resolution to the user, a regression from the previous logic that derived this flag from supportedInterfaces.

鈩癸笍 About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 馃憤.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Originally posted by @chatgpt-codex-connector[bot] in #571 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions