馃挕 Codex Review
|
const hasAddr = supportedInterfaces.indexOf('addr') > -1; |
|
const hasChainAddr = supportedInterfaces.indexOf('chainAddr') > -1; |
|
const hasMulticoin = false; |
|
const hasName = supportedInterfaces.indexOf('name') > -1; |
Multicoin resolution always disabled
The resolver UI now hard-codes hasMulticoin to false, so even when the resolver advertises the multicoin interface it will be ignored and the chain address component will never render. Any resolver that only supports multicoin (and not chainAddr) will no longer expose cross-chain address resolution to the user, a regression from the previous logic that derived this flag from supportedInterfaces.
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Originally posted by @chatgpt-codex-connector[bot] in #571 (comment)
馃挕 Codex Review
rns-manager-react/src/app/tabs/resolve/components/ResolveComponent.js
Lines 15 to 18 in 2d8c1c7
The resolver UI now hard-codes
hasMulticointofalse, so even when the resolver advertises themulticoininterface it will be ignored and the chain address component will never render. Any resolver that only supportsmulticoin(and notchainAddr) will no longer expose cross-chain address resolution to the user, a regression from the previous logic that derived this flag fromsupportedInterfaces.鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Originally posted by @chatgpt-codex-connector[bot] in #571 (comment)