Back merge 9.0.4.0 changes into master - #676
Quality Gate passed
Annotations
Check warning on line 131 in src/main/java/co/rsk/federate/util/HSMChecker.java
sonarqubecloud / SonarCloud Code Analysis
Replace this use of System.out by a logger.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl1KPHoTM0gdk4M5&open=AaBnZl1KPHoTM0gdk4M5&pullRequest=676
sonarqubecloud / SonarCloud Code Analysis
Use a static import for "times".
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZmFyPHoTM0gdk4N1&open=AaBnZmFyPHoTM0gdk4N1&pullRequest=676
Check warning on line 4275 in src/test/java/co/rsk/federate/BtcToRskClientTest.java
sonarqubecloud / SonarCloud Code Analysis
Rename "federatorSupport" which hides the field declared at line 67.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZmJVPHoTM0gdk4OK&open=AaBnZmJVPHoTM0gdk4OK&pullRequest=676
sonarqubecloud / SonarCloud Code Analysis
Use a static import for "verify".
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZmFyPHoTM0gdk4Nx&open=AaBnZmFyPHoTM0gdk4Nx&pullRequest=676
sonarqubecloud / SonarCloud Code Analysis
Use a static import for "times".
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZmFyPHoTM0gdk4Nw&open=AaBnZmFyPHoTM0gdk4Nw&pullRequest=676
Check warning on line 15 in src/main/java/co/rsk/federate/config/PowpegNodeSystemProperties.java
sonarqubecloud / SonarCloud Code Analysis
Rename this field "REGTEST" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl2XPHoTM0gdk4M_&open=AaBnZl2XPHoTM0gdk4M_&pullRequest=676
sonarqubecloud / SonarCloud Code Analysis
Use a static import for "verify".
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZmFyPHoTM0gdk4N0&open=AaBnZmFyPHoTM0gdk4N0&pullRequest=676
Check warning on line 143 in src/main/java/co/rsk/federate/util/HSMChecker.java
sonarqubecloud / SonarCloud Code Analysis
Replace this use of System.out by a logger.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl1KPHoTM0gdk4M9&open=AaBnZl1KPHoTM0gdk4M9&pullRequest=676
Check warning on line 796 in src/main/java/co/rsk/federate/BtcToRskClient.java
sonarqubecloud / SonarCloud Code Analysis
Reduce the total number of break and continue statements in this loop to use at most one.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl8HPHoTM0gdk4NH&open=AaBnZl8HPHoTM0gdk4NH&pullRequest=676
Check warning on line 94 in src/main/java/co/rsk/federate/util/HSMChecker.java
sonarqubecloud / SonarCloud Code Analysis
Replace this use of System.out by a logger.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl1KPHoTM0gdk4Mz&open=AaBnZl1KPHoTM0gdk4Mz&pullRequest=676
Check failure on line 619 in src/main/java/co/rsk/federate/BtcToRskClient.java
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 3 if/for/while/switch/try statements.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl8HPHoTM0gdk4NF&open=AaBnZl8HPHoTM0gdk4NF&pullRequest=676
Check warning on line 80 in src/main/java/co/rsk/federate/util/HSMChecker.java
sonarqubecloud / SonarCloud Code Analysis
Replace this use of System.out by a logger.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl1KPHoTM0gdk4Mw&open=AaBnZl1KPHoTM0gdk4Mw&pullRequest=676
sonarqubecloud / SonarCloud Code Analysis
Either log or rethrow this exception.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZlrhPHoTM0gdk4Mp&open=AaBnZlrhPHoTM0gdk4Mp&pullRequest=676
Check warning on line 606 in src/main/java/co/rsk/federate/BtcToRskClient.java
sonarqubecloud / SonarCloud Code Analysis
Use a primitive boolean expression here.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl8HPHoTM0gdk4ND&open=AaBnZl8HPHoTM0gdk4ND&pullRequest=676
sonarqubecloud / SonarCloud Code Analysis
Use a static import for "verify".
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZmFyPHoTM0gdk4Ny&open=AaBnZmFyPHoTM0gdk4Ny&pullRequest=676
Check failure on line 30 in src/test/java/co/rsk/federate/mock/SimpleBitcoinWrapper.java
sonarqubecloud / SonarCloud Code Analysis
Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZmIPPHoTM0gdk4N6&open=AaBnZmIPPHoTM0gdk4N6&pullRequest=676
Check warning on line 136 in src/main/java/co/rsk/federate/FederatorSupport.java
sonarqubecloud / SonarCloud Code Analysis
Disambiguate this call by either casting as "Object" or "Object[]".
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl6QPHoTM0gdk4NC&open=AaBnZl6QPHoTM0gdk4NC&pullRequest=676
Check warning on line 87 in src/main/java/co/rsk/federate/util/HSMChecker.java
sonarqubecloud / SonarCloud Code Analysis
Replace this use of System.out by a logger.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl1KPHoTM0gdk4My&open=AaBnZl1KPHoTM0gdk4My&pullRequest=676
sonarqubecloud / SonarCloud Code Analysis
Use assertThrows() instead of try/catch and fail() in the try block.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl_mPHoTM0gdk4NV&open=AaBnZl_mPHoTM0gdk4NV&pullRequest=676
Check warning on line 491 in src/test/java/co/rsk/federate/BtcToRskClientTest.java
sonarqubecloud / SonarCloud Code Analysis
Rename "federatorSupport" which hides the field declared at line 67.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZmJVPHoTM0gdk4N8&open=AaBnZmJVPHoTM0gdk4N8&pullRequest=676
sonarqubecloud / SonarCloud Code Analysis
Use assertThrows() instead of try/catch and fail() in the try block.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl9xPHoTM0gdk4NL&open=AaBnZl9xPHoTM0gdk4NL&pullRequest=676
Check warning on line 4237 in src/test/java/co/rsk/federate/BtcToRskClientTest.java
sonarqubecloud / SonarCloud Code Analysis
Rename "federatorSupport" which hides the field declared at line 67.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZmJVPHoTM0gdk4OJ&open=AaBnZmJVPHoTM0gdk4OJ&pullRequest=676
Check warning on line 70 in src/main/java/co/rsk/federate/signing/ECDSACompositeSigner.java
sonarqubecloud / SonarCloud Code Analysis
Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZlvfPHoTM0gdk4Ms&open=AaBnZlvfPHoTM0gdk4Ms&pullRequest=676
sonarqubecloud / SonarCloud Code Analysis
Use assertThrows() instead of try/catch and fail() in the try block.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl_mPHoTM0gdk4NX&open=AaBnZl_mPHoTM0gdk4NX&pullRequest=676
Check warning on line 119 in src/main/java/co/rsk/federate/util/HSMChecker.java
sonarqubecloud / SonarCloud Code Analysis
Replace this use of System.out by a logger.
See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaBnZl1KPHoTM0gdk4M2&open=AaBnZl1KPHoTM0gdk4M2&pullRequest=676