Skip to content

Set bitcoinj-thin and bitcoinj dependencies to versions that support BTC testnet4 - #654

Open
marcos-iov wants to merge 3 commits into
masterfrom
testnet2-integration
Open

Set bitcoinj-thin and bitcoinj dependencies to versions that support BTC testnet4#654
marcos-iov wants to merge 3 commits into
masterfrom
testnet2-integration

Merge branch 'master' into testnet2-integration

3676e05
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 25, 2026 in 46s

Quality Gate passed

Issues
100 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.8% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 206 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4jvso4EOfJq-DmA&open=AZ-lN4jvso4EOfJq-DmA&pullRequest=654

Check warning on line 192 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4jvso4EOfJq-Dl_&open=AZ-lN4jvso4EOfJq-Dl_&pullRequest=654

Check warning on line 3384 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "activeFederation" which hides the field declared at line 62. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4mCso4EOfJq-DmW&open=AZ-lN4mCso4EOfJq-DmW&pullRequest=654

Check warning on line 70 in src/main/java/co/rsk/federate/signing/ECDSACompositeSigner.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaA6X7Fm6UVuRSFOLoYv&open=AaA6X7Fm6UVuRSFOLoYv&pullRequest=654

Check warning on line 137 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4d3so4EOfJq-DlT&open=AZ-lN4d3so4EOfJq-DlT&pullRequest=654

Check warning on line 66 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4d3so4EOfJq-DlG&open=AZ-lN4d3so4EOfJq-DlG&pullRequest=654

Check warning on line 222 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4klso4EOfJq-DmI&open=AZ-lN4klso4EOfJq-DmI&pullRequest=654

Check warning on line 422 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "serializedOutpointValues" which hides the field declared at line 341. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4klso4EOfJq-DmN&open=AZ-lN4klso4EOfJq-DmN&pullRequest=654

Check warning on line 87 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4d3so4EOfJq-DlK&open=AZ-lN4d3so4EOfJq-DlK&pullRequest=654

Check warning on line 3453 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "activeFederation" which hides the field declared at line 62. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4mCso4EOfJq-DmZ&open=AZ-lN4mCso4EOfJq-DmZ&pullRequest=654

Check warning on line 115 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4h7so4EOfJq-Dlp&open=AZ-lN4h7so4EOfJq-Dlp&pullRequest=654

Check failure on line 581 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if/for/while/switch/try statements. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4gcso4EOfJq-Dld&open=AZ-lN4gcso4EOfJq-Dld&pullRequest=654

Check warning on line 544 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4gcso4EOfJq-Dle&open=AZ-lN4gcso4EOfJq-Dle&pullRequest=654

Check warning on line 108 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4d3so4EOfJq-DlN&open=AZ-lN4d3so4EOfJq-DlN&pullRequest=654

Check warning on line 78 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientRskMstTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4jEso4EOfJq-Dl2&open=AZ-lN4jEso4EOfJq-Dl2&pullRequest=654

Check warning on line 96 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientRskMstTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4jEso4EOfJq-Dl3&open=AZ-lN4jEso4EOfJq-Dl3&pullRequest=654

Check warning on line 15 in src/main/java/co/rsk/federate/config/PowpegNodeSystemProperties.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4ecso4EOfJq-DlY&open=AZ-lN4ecso4EOfJq-DlY&pullRequest=654

Check warning on line 71 in src/main/java/co/rsk/federate/signing/keyfile/KeyFileChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this useless assignment to local variable "privateKey". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaA6X6_-6UVuRSFOLoYu&open=AaA6X6_-6UVuRSFOLoYu&pullRequest=654

Check warning on line 267 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4klso4EOfJq-DmM&open=AZ-lN4klso4EOfJq-DmM&pullRequest=654

Check warning on line 148 in src/main/java/co/rsk/federate/PegUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either log or rethrow this exception. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4ezso4EOfJq-DlZ&open=AZ-lN4ezso4EOfJq-DlZ&pullRequest=654

Check warning on line 2233 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4klso4EOfJq-DmP&open=AZ-lN4klso4EOfJq-DmP&pullRequest=654

Check warning on line 3405 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "activeFederation" which hides the field declared at line 62. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4mCso4EOfJq-DmX&open=AZ-lN4mCso4EOfJq-DmX&pullRequest=654

Check warning on line 135 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4jvso4EOfJq-Dl8&open=AZ-lN4jvso4EOfJq-Dl8&pullRequest=654

Check warning on line 253 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-lN4h7so4EOfJq-Dlu&open=AZ-lN4h7so4EOfJq-Dlu&pullRequest=654

Check warning on line 127 in src/test/java/co/rsk/federate/signing/ECDSACompositeSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AaA6X7RC6UVuRSFOLoYy&open=AaA6X7RC6UVuRSFOLoYy&pullRequest=654
View more details on SonarQubeCloud