Skip to content

Align blocks difficulty - #647

Open
julia-zack wants to merge 5 commits into
masterfrom
align-blocks-difficulty
Open

Align blocks difficulty#647
julia-zack wants to merge 5 commits into
masterfrom
align-blocks-difficulty

Rename blocks to confirmedBlocks

68050d9
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 24, 2026 in 33s

Quality Gate passed

Issues
95 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.4% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 122 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T2MZzjgfdxh82rD&open=AZ-P6T2MZzjgfdxh82rD&pullRequest=647

Check warning on line 4212 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "federatorSupport" which hides the field declared at line 67. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T5IZzjgfdxh82rm&open=AZ-P6T5IZzjgfdxh82rm&pullRequest=647

Check warning on line 3334 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "activeFederation" which hides the field declared at line 62. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-B253J0D7dobw1LcjE&open=AZ-B253J0D7dobw1LcjE&pullRequest=647

Check warning on line 265 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T31Zzjgfdxh82ra&open=AZ-P6T31Zzjgfdxh82ra&pullRequest=647

Check warning on line 3401 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "activeFederation" which hides the field declared at line 62. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-B253J0D7dobw1LcjH&open=AZ-B253J0D7dobw1LcjH&pullRequest=647

Check warning on line 164 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T3HZzjgfdxh82rN&open=AZ-P6T3HZzjgfdxh82rN&pullRequest=647

Check warning on line 265 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T31Zzjgfdxh82rb&open=AZ-P6T31Zzjgfdxh82rb&pullRequest=647

Check warning on line 87 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-B25uL0D7dobw1Lcip&open=AZ-B25uL0D7dobw1Lcip&pullRequest=647

Check warning on line 148 in src/main/java/co/rsk/federate/PegUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either log or rethrow this exception. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-B25wM0D7dobw1Lci5&open=AZ-B25wM0D7dobw1Lci5&pullRequest=647

Check warning on line 696 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Specify a "Federation" parameter instead. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-B25yg0D7dobw1LcjA&open=AZ-B25yg0D7dobw1LcjA&pullRequest=647

Check warning on line 140 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-B25uL0D7dobw1Lciz&open=AZ-B25uL0D7dobw1Lciz&pullRequest=647

Check failure on line 582 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if/for/while/switch/try statements. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-B25yg0D7dobw1Lci9&open=AZ-B25yg0D7dobw1Lci9&pullRequest=647

Check warning on line 204 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientBtcTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T0sZzjgfdxh82q2&open=AZ-P6T0sZzjgfdxh82q2&pullRequest=647

Check warning on line 106 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T2MZzjgfdxh82rC&open=AZ-P6T2MZzjgfdxh82rC&pullRequest=647

Check warning on line 135 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T31Zzjgfdxh82rT&open=AZ-P6T31Zzjgfdxh82rT&pullRequest=647

Check warning on line 15 in src/main/java/co/rsk/federate/config/PowpegNodeSystemProperties.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this final field static too. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-B25u50D7dobw1Lci3&open=AZ-B25u50D7dobw1Lci3&pullRequest=647

Check warning on line 289 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T1XZzjgfdxh82q_&open=AZ-P6T1XZzjgfdxh82q_&pullRequest=647

Check warning on line 221 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T3HZzjgfdxh82rQ&open=AZ-P6T3HZzjgfdxh82rQ&pullRequest=647

Check warning on line 220 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T31Zzjgfdxh82rX&open=AZ-P6T31Zzjgfdxh82rX&pullRequest=647

Check warning on line 66 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-B25uL0D7dobw1Lcil&open=AZ-B25uL0D7dobw1Lcil&pullRequest=647

Check warning on line 261 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T31Zzjgfdxh82rY&open=AZ-P6T31Zzjgfdxh82rY&pullRequest=647

Check warning on line 168 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientBtcTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T0sZzjgfdxh82q0&open=AZ-P6T0sZzjgfdxh82q0&pullRequest=647

Check warning on line 4140 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "federatorSupport" which hides the field declared at line 67. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T5IZzjgfdxh82rk&open=AZ-P6T5IZzjgfdxh82rk&pullRequest=647

Check warning on line 149 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T3HZzjgfdxh82rM&open=AZ-P6T3HZzjgfdxh82rM&pullRequest=647

Check warning on line 131 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-P6T1XZzjgfdxh82q5&open=AZ-P6T1XZzjgfdxh82q5&pullRequest=647
View more details on SonarQubeCloud