Repository navigation
feat: only allow API server connections over HTTPS - #80
Merged
Merged
Conversation
The API server now requires TLS and is only started when HTTPS is enabled (via ACME or manual certificates). When --no-acme is used without manual TLS certs, the API server is disabled with a warning. The API server shares the same TLS configuration as the HTTPS server, ensuring that IP certificates obtained via HTTP-01 challenge on port 80 continue to work correctly. - API server startup moved after TLS config is established - Default API port changed from 8081 to 8443 - CLI --api-url now required (no default) - Documentation updated to reflect HTTPS requirement Closes #79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The API server now requires TLS and is only started when HTTPS is enabled (via ACME or manual certificates).
Changes
--api-urlnow required (no default)--no-acmeis used without manual TLS certs, the API server is disabled with a warningNotes
The HTTP server on port 80 remains available for ACME HTTP-01 challenges (IP certificate issuing), which is unaffected since it's a separate listener.
Closes #79