Repository navigation
feat: refactor HTTPServer to use pipeline - #77
Merged
Merged
Conversation
- Replace direct db calls with pipeline.ProcessHTTP() - Add SQLiteStore adapter implementing plugins.Store interface - Update HTTPServer to use Pipeline field instead of DB field - Create InteractionDraft and HTTPEvent from HTTP requests - Write response from HTTPResponsePlan after pipeline processing - Update all HTTP tests to use pipeline with storage and defaultresponse plugins - Update cmd/oastrix/server.go to initialize pipeline Closes #59
- Remove SQLiteStore adapter (duplicate of storage plugin functionality) - Add ResolveTokenID, CreateInteraction, SaveAttributes to storage.Plugin implementing plugins.Store interface - Update cmd/oastrix/server.go to use storagePlugin as the store - Update tests to use storagePlugin directly as store - Rename Store() to CreateInteraction() for interface compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the HTTP server to create events and dispatch through the pipeline instead of calling db functions directly.
Changes
Pipelinefield instead ofDBInteractionDraftandHTTPEventfrom HTTP requestsProcessHTTP()HTTPResponsePlanafter pipeline processingplugins.Storeinterface directly (eliminates duplication)internal/dbin http.goFiles Modified
internal/server/http.go- Refactored to use pipelineinternal/server/http_test.go- Updated tests to use pipelineinternal/plugins/core/storage/plugin.go- Implements Store interfaceinternal/plugins/core/storage/plugin_test.go- Updated testscmd/oastrix/server.go- Initialize pipeline with pluginsAcceptance Criteria
HTTPServerhasPipelinefield instead ofDBInteractionDraftandHTTPEventfrom requestHTTPResponsePlaninternal/dbin http.goCloses #59