Skip to content

use prompt_engine#357

Open
carlosmouracorreia wants to merge 6 commits intoConfigurable-voice-promptsfrom
feature/carlos-prompt-config
Open

use prompt_engine#357
carlosmouracorreia wants to merge 6 commits intoConfigurable-voice-promptsfrom
feature/carlos-prompt-config

Conversation

@carlosmouracorreia
Copy link
Copy Markdown
Collaborator

No description provided.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Sep 19, 2019

Hello @carlosmouracorreia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 56:80: E501 line too long (108 > 79 characters)

Line 218:80: E501 line too long (191 > 79 characters)
Line 231:80: E501 line too long (189 > 79 characters)
Line 235:80: E501 line too long (191 > 79 characters)
Line 240:80: E501 line too long (196 > 79 characters)
Line 243:80: E501 line too long (191 > 79 characters)
Line 248:80: E501 line too long (192 > 79 characters)
Line 251:80: E501 line too long (191 > 79 characters)
Line 273:80: E501 line too long (187 > 79 characters)
Line 278:48: W291 trailing whitespace
Line 279:80: E501 line too long (191 > 79 characters)
Line 281:80: E501 line too long (182 > 79 characters)
Line 282:80: E501 line too long (87 > 79 characters)
Line 283:21: E265 block comment should start with '# '
Line 283:80: E501 line too long (101 > 79 characters)
Line 293:80: E501 line too long (186 > 79 characters)
Line 295:25: E265 block comment should start with '# '
Line 295:80: E501 line too long (145 > 79 characters)
Line 323:13: E122 continuation line missing indentation or outdented
Line 323:80: E501 line too long (183 > 79 characters)
Line 334:1: W293 blank line contains whitespace
Line 335:13: E128 continuation line under-indented for visual indent
Line 335:80: E501 line too long (142 > 79 characters)
Line 351:17: E122 continuation line missing indentation or outdented
Line 351:80: E501 line too long (145 > 79 characters)

Comment last updated at 2019-09-23 07:45:21 UTC

else:
self.__call_handler.speak('You are calling "{0}"'.format(self.__invitee_number),
self.__prompt_engine.play_prompt(self.__prompt_engine.CALLING_OUT, self.__call_handler, self.__available_calls[self.__host.phone.raw_number]['Channel-Call-UUID'])
# CARLOS - Should the phone number be passed here - prompt engine??
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@judelove please check this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants