Skip to content

[v640] Backport recent fixes to the release branch#22067

Merged
guitargeek merged 4 commits intoroot-project:v6-40-00-patchesfrom
guitargeek:bp_1
Apr 26, 2026
Merged

[v640] Backport recent fixes to the release branch#22067
guitargeek merged 4 commits intoroot-project:v6-40-00-patchesfrom
guitargeek:bp_1

Conversation

@guitargeek
Copy link
Copy Markdown
Contributor

@guitargeek guitargeek commented Apr 26, 2026

JasMehta08 and others added 2 commits April 26, 2026 14:59
If the BLAS library is not found at configuration time, we should try to
fallback to the GSL CBLAS library, and if it still can't be found, error
out in the configuration. The branch that handles the error was already
there, but the GSL fallback was not implemented correctly.

The GSL fallback also needs to consider `builtin_gsl` correctly, and to
achieve this, finding GSL is not done after checking the required BLAS
library for TMVA CPU.

Closes root-project#22020.

(cherry picked from commit 0e45a9e)
@guitargeek guitargeek self-assigned this Apr 26, 2026
@guitargeek guitargeek requested a review from bellenot as a code owner April 26, 2026 13:20
@guitargeek guitargeek requested a review from hageboeck as a code owner April 26, 2026 13:20
nodesChildren is keyed by original graph node indices, while the parse
loop iterates over nodesOrder positions. Use nodesOrder[i] to retrieve
the correct child list for the currently parsed node and avoid incorrect
fusion pairing on reordered graphs.

(cherry picked from commit 168b17e)
@guitargeek guitargeek requested a review from lmoneta as a code owner April 26, 2026 14:52
Follows up on fa97774, which ensures that the mutation of the
computation graphs operation mode is is only happening during
minimization. There was a remnant `setOperMode(RooAbsArg::ADirty)` in
the evaluator constructor that can now be removed.

(cherry picked from commit b18bebf)
@github-actions
Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 3h 33m 2s ⏱️
 3 851 tests  3 850 ✅  1 💤 0 ❌
72 269 runs  72 251 ✅ 18 💤 0 ❌

Results for commit aa32c51.

@guitargeek guitargeek merged commit 568fc05 into root-project:v6-40-00-patches Apr 26, 2026
28 of 30 checks passed
@guitargeek guitargeek deleted the bp_1 branch April 26, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants