[core] Use automatic build tree detection for all resource directories#21018
Draft
guitargeek wants to merge 4 commits intoroot-project:masterfrom
Draft
[core] Use automatic build tree detection for all resource directories#21018guitargeek wants to merge 4 commits intoroot-project:masterfrom
guitargeek wants to merge 4 commits intoroot-project:masterfrom
Conversation
82f684f to
5bd24d2
Compare
5bd24d2 to
99e0747
Compare
Test Results 21 files 21 suites 3d 3h 17m 35s ⏱️ For more details on these failures, see this check. Results for commit 180ebb0. ♻️ This comment has been updated with latest results. |
9658e4c to
e3a4c50
Compare
pcanal
reviewed
Jan 26, 2026
301f1a6 to
0c6fb13
Compare
Member
|
https://github.com/root-project/root/actions/runs/21481040637/job/61888781030?pr=21018#step:7:18 This error probably means that ROOT cannot even start and the process segfaults. |
0c6fb13 to
493acb4
Compare
c447a98 to
70e57d8
Compare
Contributor
Author
This is fixed by that PR: |
70e57d8 to
017f67b
Compare
84ea7d7 to
160e5f1
Compare
160e5f1 to
000a6bd
Compare
This is to test that ROOT doesn't get confused at build and test time by the fact that the structure of the install tree and build tree is different, which is the case for `gnuinstall=ON`.
This follows up on a5b1ed9, using the mechanism to automatically detect if we are in the build tree or install tree also for the other resource directories (so far it was only implemented for the `include` directory as a first test). Several fallbacks and hacks can be removed because of this change, like the `ROOTIGNOREPREFIX` variable that was needed to run ROOT in the build tree for the tests.
000a6bd to
180ebb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on a5b1ed9, using the mechanism to automatically detect if we are in the build tree or install tree also for the other resource directories (so far it was only implemented for the
includedirectory as a first test).Several fallbacks and hacks can be removed because of this change, like the
ROOTIGNOREPREFIXvariable that was needed to run ROOT in the build tree for the tests.This change also makes ROOT completely independent of the
ROOTSYSenvironment variable and therefore unblocks #20006.If one wants to check that all the resource directories (inlcuding RootSys()) are correct, one can use this check: