[tmva][sofie] Add HardSwish operator for ONNX inference#20944
Open
AdityaDRathore wants to merge 2 commits intoroot-project:masterfrom
Open
[tmva][sofie] Add HardSwish operator for ONNX inference#20944AdityaDRathore wants to merge 2 commits intoroot-project:masterfrom
AdityaDRathore wants to merge 2 commits intoroot-project:masterfrom
Conversation
Implemented the HardSigmoid operator (ONNX opset 6+) for Project SOFIE. This operator is a prerequisite for supporting MobileNetV3 architectures (specifically for the HardSwish activation). Implemented in `ROperator_HardSigmoid`. - Uses hexfloat constants (`0x0p+0f`, `0x1p+0f`) for clamp bounds to ensure bit-exact reproducibility and prevent implicit double-precision promotion. - Attributes `alpha` and `beta` are strictly handled as floats to avoid `CVTSS2SD` overhead in the generated inference loop. - Added GTest suite `TestSofieHardSigmoid` validating numerical correctness against SciPy data and verifying AVX-friendly code generation.
The SOFIE inference engine lacks the 'HardSwish' operator, which is a critical activation function for MobileNetV3 and other modern lightweight architectures (ONNX Opset 14). - Implemented `TMVA::Experimental::SOFIE::ROperator_HardSwish` as a standalone inline operator. - Utilized `std::fmax` and `std::fmin` with strict hexfloat constants (1/6 and 0.5) to ensure AVX optimization and prevent double-precision promotion. - Registered the operator in `RModelParser_ONNX` with an inline lambda. - Added comprehensive unit tests (`TestSofieHardSwish`) verifying numerical correctness and generated code topology.
Contributor
Author
|
This branch is built on top of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request
This PR implements the
HardSwishoperator for the SOFIE engine. This operator is required for supporting MobileNetV3 architectures.Note on Dependency:
This PR is stacked on top of PR #20933 (HardSigmoid). It includes the commits from that PR. The unique changes for this PR are contained in the
HardSwishoperator files.Changes or fixes:
New Operator: Implemented
TMVA::Experimental::SOFIE::ROperator_HardSwish.HardSigmoidto minimize function overhead.std::fmaxandstd::fminwith bit-exact hexfloat constants:0x1.5555555555555p-3f(approx 1/6)0x1p-1f(0.5)0x0p+0fand0x1p+0f(Clamp bounds)RModelParser_ONNXto registerHardSwish(Opset 14 compliant).Validation: Added
TestSofieHardSwishGTest suite.x * max(0, min(1, x/6 + 0.5)).float h = ...).Checklist:
TestSofieHardSwishpassing )This PR fixes # (No specific issue linked, strictly feature addition)
cc: @guitargeek @moneta @devajithvs @bellenot