Skip to content

fix const typo => EFunctionCallBeyondSessionScope #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jolestar merged 1 commit into from
Aug 16, 2023
Merged

fix const typo => EFunctionCallBeyondSessionScope #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/rooch-framework-tests/src/tests/transaction_validator_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ fn test_session_key_ed25519() {
// _ => panic!("expect move abort in module"),
// }
// let (_category, reason) = error::explain(code);
// // EFunctionCallBeyoundSessionScope = 5
// assert_eq!(reason, 5, "expect EFunctionCallBeyoundSessionScope");
// // EFunctionCallBeyondSessionScope = 5
// assert_eq!(reason, 5, "expect EFunctionCallBeyondSessionScope");
// }
// _ => panic!("expect move abort"),
// }
Expand Down
6 changes: 3 additions & 3 deletions crates/rooch-framework/doc/session_key.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,12 @@ The session's scope
## Constants


<a name="0x3_session_key_EFunctionCallBeyoundSessionScope"></a>
<a name="0x3_session_key_EFunctionCallBeyondSessionScope"></a>

The function call is beyond the session's scope


<pre><code><b>const</b> <a href="session_key.md#0x3_session_key_EFunctionCallBeyoundSessionScope">EFunctionCallBeyoundSessionScope</a>: u64 = 5;
<pre><code><b>const</b> <a href="session_key.md#0x3_session_key_EFunctionCallBeyondSessionScope">EFunctionCallBeyondSessionScope</a>: u64 = 5;
</code></pre>


Expand Down Expand Up @@ -400,7 +400,7 @@ If the session key is expired or invalid, abort the tx, otherwise return option:
<b>let</b> <a href="session_key.md#0x3_session_key">session_key</a> = <a href="_extract">option::extract</a>(&<b>mut</b> session_key_option);
<b>assert</b>!(!<a href="session_key.md#0x3_session_key_is_expired">is_expired</a>(ctx, &<a href="session_key.md#0x3_session_key">session_key</a>), <a href="_permission_denied">error::permission_denied</a>(<a href="session_key.md#0x3_session_key_ESessionIsExpired">ESessionIsExpired</a>));

<b>assert</b>!(<a href="session_key.md#0x3_session_key_in_session_scope">in_session_scope</a>(ctx, &<a href="session_key.md#0x3_session_key">session_key</a>), <a href="_permission_denied">error::permission_denied</a>(<a href="session_key.md#0x3_session_key_EFunctionCallBeyoundSessionScope">EFunctionCallBeyoundSessionScope</a>));
<b>assert</b>!(<a href="session_key.md#0x3_session_key_in_session_scope">in_session_scope</a>(ctx, &<a href="session_key.md#0x3_session_key">session_key</a>), <a href="_permission_denied">error::permission_denied</a>(<a href="session_key.md#0x3_session_key_EFunctionCallBeyondSessionScope">EFunctionCallBeyondSessionScope</a>));

validator::validate_signature(&authenticator_payload, &<a href="_tx_hash">storage_context::tx_hash</a>(ctx));
<a href="_some">option::some</a>(auth_key)
Expand Down
Binary file modified crates/rooch-framework/error_description.errmap
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions crates/rooch-framework/sources/session_key.move
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module rooch_framework::session_key {
/// The session is expired
const ESessionIsExpired: u64 = 4;
/// The function call is beyond the session's scope
const EFunctionCallBeyoundSessionScope: u64 = 5;
const EFunctionCallBeyondSessionScope: u64 = 5;

/// The session's scope
struct SessionScope has store,copy,drop {
Expand Down Expand Up @@ -131,7 +131,7 @@ module rooch_framework::session_key {
let session_key = option::extract(&mut session_key_option);
assert!(!is_expired(ctx, &session_key), error::permission_denied(ESessionIsExpired));

assert!(in_session_scope(ctx, &session_key), error::permission_denied(EFunctionCallBeyoundSessionScope));
assert!(in_session_scope(ctx, &session_key), error::permission_denied(EFunctionCallBeyondSessionScope));

validator::validate_signature(&authenticator_payload, &storage_context::tx_hash(ctx));
option::some(auth_key)
Expand Down